You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/01/02 13:57:00 UTC
[GitHub] [skywalking] wu-sheng opened a new pull request #4164: Add the new
protocol for client-js agent
wu-sheng opened a new pull request #4164: Add the new protocol for client-js agent
URL: https://github.com/apache/skywalking/pull/4164
The implementation will be submitted in the next few days. Sync this first to avoid conflicts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng merged pull request #4164: Add the new
protocol for client-js agent
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #4164: Add the new protocol for client-js agent
URL: https://github.com/apache/skywalking/pull/4164
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4164: Add the new
protocol for client-js agent
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4164: Add the new protocol for client-js agent
URL: https://github.com/apache/skywalking/pull/4164#issuecomment-570234938
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4164?src=pr&el=h1) Report
> Merging [#4164](https://codecov.io/gh/apache/skywalking/pull/4164?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/7902c6242fca7cc66d6f6d1858711a3b3fa7594e?src=pr&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4164?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4164 +/- ##
=========================================
- Coverage 26.86% 26.8% -0.06%
=========================================
Files 1160 1160
Lines 25381 25381
Branches 3682 3682
=========================================
- Hits 6818 6804 -14
- Misses 17955 17972 +17
+ Partials 608 605 -3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4164?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../core/remote/ServiceAndEndpointRegisterClient.java](https://codecov.io/gh/apache/skywalking/pull/4164/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VBbmRFbmRwb2ludFJlZ2lzdGVyQ2xpZW50LmphdmE=) | `31.46% <0%> (-13.49%)` | :arrow_down: |
| [...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4164/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==) | `73.77% <0%> (-3.28%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4164?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4164?src=pr&el=footer). Last update [7902c62...1c3eb0c](https://codecov.io/gh/apache/skywalking/pull/4164?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services