[jira] Commented: (CASSANDRA-2146) cli read_repair_chance input not validated

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-2146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12993240#comment-12993240 ] 

Hudson commented on CASSANDRA-2146:
-----------------------------------

Integrated in Cassandra-0.7 #276 (See [https://hudson.apache.org/hudson/job/Cassandra-0.7/276/])
    validate read_repair_chance
patch by xedin; reviewed by jbellis for CASSANDRA-2146


> cli read_repair_chance input not validated
> ------------------------------------------
>
>                 Key: CASSANDRA-2146
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2146
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7.0
>            Reporter: Chris Burroughs
>            Assignee: Pavel Yaskevich
>            Priority: Minor
>             Fix For: 0.7.2
>
>         Attachments: CASSANDRA-2146.patch
>
>   Original Estimate: 0.5h
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> {noformat}
> put(ColumnFamilyArgument.READ_REPAIR_CHANCE, "Probability (0.0-1.0) with which to perform read repairs on CL.ONE reads");
> {noformat}
> The input range is not enforced so 
> {noformat}
> create column family ... with ... read_repair_chance = 25;
> {noformat}
> Will result in
> {noformat}
> Keyspace: ks1:
>   Replication Strategy: org.apache.cassandra.locator.SimpleStrategy
>     Replication Factor: 3
>   Column Families:
>     ColumnFamily: cf1
>       Columns sorted by: org.apache.cassandra.db.marshal.UTF8Type
> ...
>       Read repair chance: 25.0
> {noformat}
> I am unsure if in practice this means RR chance 100%, or something surprising.  (I ran into this because read_repair_chance requires a leading 0 and ommiting it results in an unhelpful "Command not found:" message).

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira