You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "jackwener (via GitHub)" <gi...@apache.org> on 2023/01/27 15:45:29 UTC

[GitHub] [hudi] jackwener commented on pull request #7756: [MINOR] remove useless code.

jackwener commented on PR #7756:
URL: https://github.com/apache/hudi/pull/7756#issuecomment-1406678455

   has resolve the Problem.
   It's caused by that I remove  `boolean hasNext = hasNext();`
   
   I think code may exist problem.
   Look like we didn't handle the condition that `hasNext()` return false.
   ```
       // TODO: when hasNext is false, we should not call next()
       boolean hasNext = hasNext();
   ```
   
   I just read source code recently and I don't know about HUDI well. So, I don't ensure whether it exist problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org