You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/12/24 08:41:41 UTC

[GitHub] [fineract] ptuomola opened a new pull request #2001: FINERACT-1452: Disallow changing of password of specific users

ptuomola opened a new pull request #2001:
URL: https://github.com/apache/fineract/pull/2001

## Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).

## Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests

- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

- [ ] Create/update unit or integration tests for verifying the changes made.

- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes

- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] vorburger commented on pull request #2001: FINERACT-1452: Disallow changing of password of specific users

Posted by GitBox <gi...@apache.org>.

vorburger commented on pull request #2001:
URL: https://github.com/apache/fineract/pull/2001#issuecomment-1002186052


   This looks very interesting, for https://github.com/vorburger/www.fineract.dev/issues/5.
   
   I'm going to review this PR, merge it when it LGTM, and use it on Fineract.dev...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] vorburger merged pull request #2001: FINERACT-1452: Disallow changing of password of specific users

Posted by GitBox <gi...@apache.org>.

vorburger merged pull request #2001:
URL: https://github.com/apache/fineract/pull/2001


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] vorburger commented on a change in pull request #2001: FINERACT-1452: Disallow changing of password of specific users

Posted by GitBox <gi...@apache.org>.

vorburger commented on a change in pull request #2001:
URL: https://github.com/apache/fineract/pull/2001#discussion_r775987746



##########
File path: fineract-provider/src/main/resources/sql/migrations/core_db/V379__user_cannot_change_password.sql
##########
@@ -0,0 +1,20 @@
+--

Review comment:
       I've verified that the last one in https://github.com/apache/fineract/tree/develop/fineract-provider/src/main/resources/sql/migrations/core_db is 378, so this at 379 LGTM.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] ptuomola commented on pull request #2001: FINERACT-1452: Disallow changing of password of specific users

Posted by GitBox <gi...@apache.org>.

ptuomola commented on pull request #2001:
URL: https://github.com/apache/fineract/pull/2001#issuecomment-1000727822


   @vorburger How about something as simple as this to stop the people changing the password? When setting up the instance you could just run "update fineract_default.m_appuser set cannot_change_password = 1 where id = 1;" to enable this for the admin user. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org