You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/05/30 06:42:36 UTC
[GitHub] [incubator-druid] clintropolis commented on a change in pull
request #7799: Web-console: update supervisors table
clintropolis commented on a change in pull request #7799: Web-console: update supervisors table
URL: https://github.com/apache/incubator-druid/pull/7799#discussion_r288875741
##########
File path: web-console/src/views/task-view/tasks-view.tsx
##########
@@ -109,6 +109,22 @@ function statusToColor(status: string): string {
}
}
+function detailedStatusToColor(status: string): string {
Review comment:
I think coloring should be probably tied to `status` instead of `detailedStatus`, as `detailedStatus` is messaging specific to the type of supervisor, and 'status' is intended to be universal. Values are:
```
UNHEALTHY_SUPERVISOR
UNHEALTHY_TASKS
PENDING
RUNNING
SUSPENDED
STOPPING
```
See https://github.com/apache/incubator-druid/pull/7428/files#diff-290822ceec7682a31578278f881dad70R58
To me it probably makes sense to use 'status' to set the color, but maybe display the detailed messaging?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org