You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Kirk Lund <ki...@gmail.com> on 2017/05/19 00:36:31 UTC
Review Request 59386: GEODE-2929: remove superfluous uses of final to
facilitate mocking
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59386/
-----------------------------------------------------------
Review request for geode, Anthony Baker, Bruce Schuchardt, Darrel Schneider, Jinmei Liao, Jared Stewart, Ken Howe, Patrick Rhomberg, and Dan Smith.
Bugs: GEODE-2929
https://issues.apache.org/jira/browse/GEODE-2929
Repository: geode
Description
-------
This is the last batch of changes to remove final modifiers from methods so they can be mocked in unit tests. I also added new unit tests for some of the classes to verify that the class and its previously-final methods can be mocked.
Diffs
-----
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestInterfaceJUnitTest.java 324284e6bcddcbfe312d10629db2215b019b8769
geode-core/src/main/java/org/apache/geode/CancelCriterion.java fec38272b75fe8081e140784a13ff76eb5c6bbf4
geode-core/src/main/java/org/apache/geode/CanonicalInstantiator.java 10e6f164ca9dcd444ce722d14cc514c170c33a92
geode-core/src/main/java/org/apache/geode/DataSerializer.java 34501f8496707843b7e9546e4fb486466f16001a
geode-core/src/main/java/org/apache/geode/Instantiator.java e4da556ed398b73c21dcfd975db03194b03a7e18
geode-core/src/main/java/org/apache/geode/admin/RegionSubRegionSnapshot.java 19f89b251f2ccf4a553c619500a855217b9ee064
geode-core/src/main/java/org/apache/geode/cache/DiskAccessException.java e77e485f7349a0179eb31b80f30ea6ccecf982fa
geode-core/src/main/java/org/apache/geode/cache/DynamicRegionFactory.java 9bf14cdfe2fc22965a9b929e927c4ff50dd115d3
geode-core/src/main/java/org/apache/geode/cache/EvictionAction.java a8513d96cf91599b182844a32b960ec6f5e77b4b
geode-core/src/main/java/org/apache/geode/cache/EvictionAlgorithm.java 96b55b6af048bfa1ab487a70e85d456d9d1d9dd7
geode-core/src/main/java/org/apache/geode/cache/EvictionAttributes.java 8c30b30a224b54e3d059a5191473833982f4561b
geode-core/src/main/java/org/apache/geode/cache/FixedPartitionAttributes.java dd8bd94ed983b99ae35529dfc5816e363340d6e3
geode-core/src/main/java/org/apache/geode/cache/MembershipAttributes.java 79f7d8aaeef89590fdd5290d6c403eb13da21589
geode-core/src/main/java/org/apache/geode/cache/client/internal/AbstractOp.java 593375e62bbe34aa129643d27472bc9d6dea2460
geode-core/src/main/java/org/apache/geode/cache/execute/FunctionException.java 3198b0d17b962b538e3c207274c28d7c5b3358a9
geode-core/src/main/java/org/apache/geode/cache/query/internal/ObjectIntHashMap.java d0cf5dbae0777522fa1436e73a0d50ceb9110502
geode-core/src/main/java/org/apache/geode/compression/SnappyCompressor.java 63248235d7eb6990101fdb6532d72cee44b40ac5
geode-core/src/main/java/org/apache/geode/distributed/AbstractLauncher.java feba8937b216d374acd8357775d5d1806568b355
geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java 641e009d5e9fe646684fe65d91110805fe589b91
geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java b2d01511e4868b7055521901d378aa5efaefe203
geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionAdvisor.java 4eb988836ca44257c8f5248d4fe08ce321b73896
geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionManager.java f4e547fa3d196e20844b00f0f10bd2ca51a2069a
geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionMessage.java 403b4205f74a919e58648227937e68b90f681215
geode-core/src/main/java/org/apache/geode/distributed/internal/ReplyProcessor21.java 7e87c8c8b4bdded4a15fa4ce7e71ebfd519f717e
geode-core/src/main/java/org/apache/geode/internal/AbstractConfig.java 101ee63a138b64e82d87968b3fd2012888dbc1ca
geode-core/src/main/java/org/apache/geode/internal/HeapDataOutputStream.java ae281200384387440d6fdd9dcd8532a78f5a7198
geode-core/src/main/java/org/apache/geode/internal/ObjIdConcurrentMap.java 17894ad51428112c4c635b307a25047a8420621a
geode-core/src/main/java/org/apache/geode/internal/SharedLibrary.java 7faebe9de784946f29cd062c7fda492071e1d7c7
geode-core/src/main/java/org/apache/geode/internal/SystemTimer.java 16227d25b467012e5c121de243d775a467ce1808
geode-core/src/main/java/org/apache/geode/internal/cache/AbstractDiskRegion.java 81011d3a2863e5d387b0c4ac8b55d17437287836
geode-core/src/main/java/org/apache/geode/internal/cache/AbstractLRURegionMap.java bcaa0d08ef430f530abb4323ef2e5dbf40265b32
geode-core/src/main/java/org/apache/geode/internal/cache/AbstractOplogDiskRegionEntry.java 866ff036860eec8410728779d157ff22ac50f61b
geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegion.java ac5fb37fa76c6ab5fd0832fb7a72bbc73fcfa7f1
geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegionMap.java 5dcf3bca28f3e1e6af8ad13a9d6ee18d3b8a342d
geode-core/src/main/java/org/apache/geode/internal/cache/BucketAdvisor.java 04a48d09d1920adbcf688f86ec6943cda3603706
geode-core/src/main/java/org/apache/geode/internal/cache/DestroyOperation.java ad3f976d84bd177c21be942e851e26ee1272c06b
geode-core/src/main/java/org/apache/geode/internal/cache/DistPeerTXStateStub.java 641135385bee9296d26762e448a339ec16d99a1e
geode-core/src/main/java/org/apache/geode/internal/cache/DistributedCacheOperation.java 6c33c655ad4de93ec8b20874a4250f353d1c034b
geode-core/src/main/java/org/apache/geode/internal/cache/DistributedPutAllOperation.java c26cd567d55c79ea26860f202991ed98225e466a
geode-core/src/main/java/org/apache/geode/internal/cache/DistributedRegion.java 485835b55f98d07ae201643c06aa35c151205164
geode-core/src/main/java/org/apache/geode/internal/cache/DistributedRegionFunctionStreamingMessage.java 870e77841b09d3c84a1089f9781b68261b0ca240
geode-core/src/main/java/org/apache/geode/internal/cache/DistributedRemoveAllOperation.java 42bf10f720c723e5bb7bfef125274c9d71a1e8d9
geode-core/src/main/java/org/apache/geode/internal/cache/ExpiryTask.java 1d65579647bed4f1abfd4dce667185e6e9df09b5
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 4ed583a7506f46876567ff69d1842f55a39d5418
geode-core/src/main/java/org/apache/geode/internal/cache/GridAdvisor.java 8d28a5318ccc646f064e9f5e8188cb1686edf362
geode-core/src/main/java/org/apache/geode/internal/cache/InitialImageOperation.java fb5f0cf9754c537897e3ea86568687c6cb95b6cb
geode-core/src/main/java/org/apache/geode/internal/cache/MemberFunctionStreamingMessage.java 3a0bf8e70130975a9a64570b844f8f0729835a1e
geode-core/src/main/java/org/apache/geode/internal/cache/NonLocalRegionEntry.java 805b900dcf49d4afb8de6a87525707924b05bb0e
geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionDataStore.java b171a95c4116599fcb94c20fe14d842a662f9cf8
geode-core/src/main/java/org/apache/geode/internal/cache/PlaceHolderDiskRegion.java 097ca412f38312ec1206897eda739dcc712a20a8
geode-core/src/main/java/org/apache/geode/internal/cache/ProxyBucketRegion.java cfc9fdd24cd75a884e5ffeab06008929bf25ab4d
geode-core/src/main/java/org/apache/geode/internal/cache/RemoteFetchEntryMessage.java 913836a9dab4f80179bb7c5210eab7869269c68b
geode-core/src/main/java/org/apache/geode/internal/cache/RemotePutAllMessage.java 0e9f8c5510e58fb54d338e0894a7657b8e88c868
geode-core/src/main/java/org/apache/geode/internal/cache/RemoteRemoveAllMessage.java d4d4c265dca63044a2a4277ec26719ef2f7b3ffb
geode-core/src/main/java/org/apache/geode/internal/cache/StateFlushOperation.java 3ad11371f07f007af61f7151fa916ec14f0cca60
geode-core/src/main/java/org/apache/geode/internal/cache/TXEvent.java 95c2cc21e9a9c552b117b3d715685b34b1bbeb20
geode-core/src/main/java/org/apache/geode/internal/cache/TXId.java 32fe284348c8941ca963fd294d3312293442427c
geode-core/src/main/java/org/apache/geode/internal/cache/TXMessage.java 24cbaa2ed8e28fc395400afc027875a7924d9170
geode-core/src/main/java/org/apache/geode/internal/cache/TXState.java 6a6e9ad1fed02690f11a9fa19ab9801fe9c50952
geode-core/src/main/java/org/apache/geode/internal/cache/TXStateStub.java 5dd624b8080001d95d04a4ecfb779bf1198bf07d
geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsDiskLRURegionEntryHeap.java 3c0dd9b8f46e236023db2a7ff58b36ea21545812
geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsDiskLRURegionEntryOffHeap.java d8f508397eeb9526b4cdbbe05d6cc9050fa9c693
geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsDiskRegionEntryHeap.java c193444396e1d74cb1a686211b42cec7eb1d1421
geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsDiskRegionEntryOffHeap.java 9ec129f165dcf29b20c20c2dea8386d9ff7c18c0
geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsLRURegionEntryHeap.java 16c10131da22ed49c1046a4d91bbf9210d75dbab
geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsLRURegionEntryOffHeap.java 52d7f6f0455857722c5cbd0352c6da77c1cb07f9
geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsRegionEntryHeap.java ce3641b298293af236ba3448c7b73962cb8c30a1
geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsRegionEntryOffHeap.java 1689a8ff23218d0efc6fdb2266f28b8876f3dd5a
geode-core/src/main/java/org/apache/geode/internal/cache/VMThinDiskLRURegionEntryHeap.java 24bd9f4d06fa6cb48961a05a697b26a3d07a4747
geode-core/src/main/java/org/apache/geode/internal/cache/VMThinDiskLRURegionEntryOffHeap.java 20a412703aa36275864e90264c5bbbdafbac2d0d
geode-core/src/main/java/org/apache/geode/internal/cache/VMThinDiskRegionEntryHeap.java 27b5a5a9718d6b7a99ba87d8e41349a93e4b87ae
geode-core/src/main/java/org/apache/geode/internal/cache/VMThinDiskRegionEntryOffHeap.java e900c2c2774d15ab52965b25f8704b52431594d1
geode-core/src/main/java/org/apache/geode/internal/cache/VMThinLRURegionEntryHeap.java 44ba28377d166c6203ad158aa5c2eb42f90b3b5f
geode-core/src/main/java/org/apache/geode/internal/cache/VMThinLRURegionEntryOffHeap.java 9ed657dea28205dc3004380d33e1baf72c5dc06d
geode-core/src/main/java/org/apache/geode/internal/cache/VMThinRegionEntryHeap.java 3666a0a3391de093b4e0dc628ca10514c7aa57f0
geode-core/src/main/java/org/apache/geode/internal/cache/VMThinRegionEntryOffHeap.java 6426df045de49fd999a04caf63ad3bd50a4103e8
geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsDiskLRURegionEntryHeap.java 6c7bc91b38cfcf43f22e7ba4e18342642ed124d9
geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsDiskLRURegionEntryOffHeap.java 8b38a2b4a94c40134956f9625e0dd4566b55f716
geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsDiskRegionEntryHeap.java c6bdf9390dc9808822c7d336d17f4d76acc5c6b8
geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsDiskRegionEntryOffHeap.java d2f1dcf5cc7e78f5b88dea43a876d3039b2df544
geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsLRURegionEntryHeap.java 6978d5192b09b1b40635a103c14689e93fad6533
geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsLRURegionEntryOffHeap.java f46bcbf5212c216296d51c69c72c13ac324a5387
geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsRegionEntryHeap.java 55dc5efd0032a1d41abaffd98d94329916c95a62
geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsRegionEntryOffHeap.java 2fe12c1618f27de9670704e3cc37b03cad539c17
geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinDiskLRURegionEntryHeap.java 1eec3e977a2770fb0fe8a43a81d33c49b985bcee
geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinDiskLRURegionEntryOffHeap.java e82a0aaf51e4f3c555a4c375e4283b84f3ec5988
geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinDiskRegionEntryHeap.java 42d8564927d606be8be64378ca0b677940f6f758
geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinDiskRegionEntryOffHeap.java 4bdb7a4c0760979b42f3d64cdae759e19df25029
geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinLRURegionEntryHeap.java fb260be63a3f02f823d7274fe33f2d260127972f
geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinLRURegionEntryOffHeap.java 1286bb67eaaa2198ca4f8191cc9c768d240295d6
geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinRegionEntryHeap.java 6071836f113d52c4c77c2934906e000de8a5e8b2
geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinRegionEntryOffHeap.java 21c1806d4d8c4cb7d7cca0f873ae2abcfeb8e1a4
geode-core/src/main/java/org/apache/geode/internal/cache/control/ResourceAdvisor.java da0c19015d6efa422fd761b2eda8e408c8b3c854
geode-core/src/main/java/org/apache/geode/internal/cache/locks/TXLockIdImpl.java 0fd607cd93aa7a7c2580aa2f6d3efa7fab6a9e1f
geode-core/src/main/java/org/apache/geode/internal/cache/lru/LRUAlgorithm.java 9b69c7e89d3c1f2d9db774c95685b27ceee6e9e8
geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/BucketBackupMessage.java 8d164c87bd8836daff80701372eb4fe068c6f039
geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/DeposePrimaryBucketMessage.java f1633bd63d9b73c681922d0505893eb2c6978208
geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/FetchEntryMessage.java 664ebe7702a947c3d57c3adb7a091114e3d1e704
geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/FetchPartitionDetailsMessage.java 21dfa8d534d2b1e653fa1e834ae951ffa724ef70
geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/MoveBucketMessage.java 6f180130f280692460dcda5798af16b47903c66f
geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PartitionMessage.java 6b59f51c8de25bd4af075c3172cd51dfc7132dac
geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/RemoveAllPRMessage.java 7ee54d8e7d5b638b0f285ff6a64a27b32aee56df
geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/RemoveBucketMessage.java a8ff068edfeaf99e24bc61b151ee91e58cc7461b
geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/SizeMessage.java 0c6aea80bc66b65ef5cf46d394d3feac719ea4b2
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientUpdater.java 728abf70296d6adcf724135a9e852c261216b981
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/Part.java 889980f1ddf386cdd5f8d62ea073574d3dd2d2e1
geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java 39f30d6c1c208ec09ca220f4b55e7c010becdfbf
geode-core/src/main/java/org/apache/geode/internal/cache/wan/serial/BatchDestroyOperation.java d38b2c741021db98eb085fc8e3e81407091abd6f
geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/CacheTransactionManagerCreation.java 950166688c8d72fe5b3beed65459fdbc1272b795
geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/CacheXmlVersion.java 413fc4ab8eb8f738cdd6a8d1cc45f2010b8a541c
geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/DefaultEntityResolver2.java 728cab49e2bbbe0572b553b5e1388f638e0f1933
geode-core/src/main/java/org/apache/geode/internal/statistics/StatArchiveWriter.java 3d375adfd518eac7fd6774405447320c63fd60bd
geode-core/src/main/java/org/apache/geode/internal/tcp/Connection.java e59821d0dcffbd127b940c8e8ff48a24195dd7e5
geode-core/src/main/java/org/apache/geode/management/internal/IdentityConverter.java ce5ba45db861c5bbac3b33547ac8c48535754f27
geode-core/src/main/java/org/apache/geode/management/internal/OpenTypeConverter.java 4fdf291b3655ddf53feef4bf6a207717578884c5
geode-core/src/main/java/org/apache/geode/management/internal/cli/json/TypedJson.java fd9461f0d97f2f8d8307f478a5e9d1af70d73327
geode-core/src/main/java/org/apache/geode/management/internal/web/domain/Link.java cef8cabf109e958937a17b46e8d9935980de9511
geode-core/src/main/java/org/apache/geode/management/internal/web/http/ClientHttpRequest.java ea9c81cf3f5c4a1f1a69fd0cf5e7affe086b9d6f
geode-core/src/main/java/org/apache/geode/redis/internal/executor/AbstractScanExecutor.java 0eb6dcad38327f5b1bab39250366461ee69944b0
geode-core/src/test/java/org/apache/geode/DataSerializerTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/InstantiatorTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/admin/RegionSubRegionSnapshotTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/cache/ConnectionPoolFactoryJUnitTest.java 18af019007fd710caf30a027c999b6562bfaa46c
geode-core/src/test/java/org/apache/geode/cache/DiskAccessExceptionTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/cache/client/internal/AbstractOpTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/cache/execute/FunctionExceptionTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/cache/query/functional/PdxOrderByJUnitTest.java 9655ab453f94a5eb7a352013c88bc13647dc4816
geode-core/src/test/java/org/apache/geode/cache/query/internal/index/ConcurrentIndexUpdateWithInplaceObjectModFalseDUnitTest.java 1700ccd7cb3ab5460d3a7396781abc8f742108c6
geode-core/src/test/java/org/apache/geode/cache30/CacheSerializableRunnable.java cfd75babaaf5979420498d03785f3034963e631d
geode-core/src/test/java/org/apache/geode/cache30/RegionTestCase.java db92dc844906bc76aeb81f58f1f3d428625a6d2b
geode-core/src/test/java/org/apache/geode/cache30/TXDistributedDUnitTest.java c8a629ccf19e2dcf09548565012ac16e567a05ae
geode-core/src/test/java/org/apache/geode/cache30/TestCacheCallback.java 37f67e8c3119fe79ab70e565f362ed22f9146629
geode-core/src/test/java/org/apache/geode/cache30/TestCacheListener.java db318d558588966205491066cd302e1c2a60cd1e
geode-core/src/test/java/org/apache/geode/cache30/TestCacheLoader.java d9158a5ec9364853600958318e50e53f4148fcd2
geode-core/src/test/java/org/apache/geode/cache30/TestCacheWriter.java 95d7f75b5843196f3cbd3e637bdf9bd9e46170c8
geode-core/src/test/java/org/apache/geode/cache30/TestTransactionListener.java 2b75ccc1189a126869d7fb103aabbb518cbe22ca
geode-core/src/test/java/org/apache/geode/distributed/AbstractLauncherTest.java 62d4bdd443d02aef910074e8b20d3963d7d1d301
geode-core/src/test/java/org/apache/geode/distributed/AbstractLocatorLauncherRemoteIntegrationTestCase.java 2a6dfa64f9b44acf224372d5da3f72dcf99ba525
geode-core/src/test/java/org/apache/geode/distributed/AbstractServerLauncherRemoteIntegrationTestCase.java d3aa05ba97c439c84bbaa1921032c7e520c8b0c8
geode-core/src/test/java/org/apache/geode/distributed/LocatorLauncherTest.java 06d6054f524a4fd31fc8b8189b24aa3def10babd
geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherTest.java f5d6271c3a3d598973b28c7423f609961dbc8272
geode-core/src/test/java/org/apache/geode/distributed/internal/DistributionAdvisorTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/distributed/internal/DistributionManagerTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/distributed/internal/DistributionMessageTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/distributed/internal/ReplyProcessor21Test.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/AbstractConfigTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/DataSerializableJUnitTest.java 2f853db5b00f08a9f5c12f76b7de56ffaf95db99
geode-core/src/test/java/org/apache/geode/internal/HeapDataOutputStreamTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/ObjIdConcurrentMapTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/AbstractDiskRegionTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/AbstractLRURegionMapTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/AbstractOplogDiskRegionEntryTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/AbstractRegionMapTest.java eee588e20318029f9110b382102e3f82a70de2d9
geode-core/src/test/java/org/apache/geode/internal/cache/AbstractRegionTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/BucketAdvisorTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/Bug37377DUnitTest.java 3d0be6ae7214564b9403b7d197346c558b674cab
geode-core/src/test/java/org/apache/geode/internal/cache/Bug39079DUnitTest.java 6dc52badbffb797db4f822f550aefeb220f06348
geode-core/src/test/java/org/apache/geode/internal/cache/CacheOperationMessageTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/DestroyMessageTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/DiskRegCacheXmlJUnitTest.java dd29c7445de82fff463a2baef6089b44a091be6f
geode-core/src/test/java/org/apache/geode/internal/cache/DiskRegionClearJUnitTest.java 63e6d62ec20c908adfd27b553cdaeea538a0599c
geode-core/src/test/java/org/apache/geode/internal/cache/DiskRegionTestingBase.java 913d56d0973d70d152d3abfa4a1b5810858f56be
geode-core/src/test/java/org/apache/geode/internal/cache/DistPeerTXStateStubTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/DistributedCacheOperationTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/DistributedPutAllOperationTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/DistributedRegionFunctionStreamingMessageTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/DistributedRegionTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/DistributedRemoveAllOperationTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/ExpiryTaskTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/GemFireCacheImplTest.java a24fc5a0898ea4276ce3b0ac28a8ba703708ec30
geode-core/src/test/java/org/apache/geode/internal/cache/GridProfileTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/MemberFunctionStreamingMessageTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/NonLocalRegionEntryTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionBucketCreationDistributionDUnitTest.java ed23f2add324a5402405623972ce1160816371d7
geode-core/src/test/java/org/apache/geode/internal/cache/PlaceHolderDiskRegionTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/ProxyBucketRegionTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/RemoteFetchEntryMessageTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/RemotePutAllMessageTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/RemoteRemoveAllMessageTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/RequestFilterInfoMessageTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/RequestImageMessageTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/RequestRVVMessageTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/StateMarkerMessageTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/TXEventTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/TXMessageTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/TXStateStubTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/UnzipUtil.java f6558c04f018dd776c406d8a78258eefe27e565c
geode-core/src/test/java/org/apache/geode/internal/cache/control/ResourceAdvisorTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/ha/ConflatableObject.java 438d9380e4e8d189245441435762b0d4f06e7403
geode-core/src/test/java/org/apache/geode/internal/cache/lru/LRUAlgorithmTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/BucketBackupMessageTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/ColocatedRegionDetailsJUnitTest.java b95e11ae79f21c6e688a19730d27559beb436657
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/DeposePrimaryBucketMessageTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/FetchEntryMessageTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/FetchPartitionDetailsMessageTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/MoveBucketMessageTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/PartitionMessageTest.java b3bb02b51e6cb662c0bd6d96e9cf41c753e6e7f7
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/RemoveAllPRMessageTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/RemoveBucketMessageTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/SizeMessageTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/CCUStatsTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/PartTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/versions/RegionVersionHolderJUnitTest.java 0514e1941db9a48df907910bf30b4263f028430d
geode-core/src/test/java/org/apache/geode/internal/cache/versions/TombstoneDUnitTest.java e178708a259d8f07162f31a42899ae16cc9c0e34
geode-core/src/test/java/org/apache/geode/internal/cache/wan/AsyncEventQueueTestBase.java 5d4fd98de29c693528c48bfce6da3645e55185e0
geode-core/src/test/java/org/apache/geode/internal/cache/wan/asyncqueue/AsyncEventQueueValidationsJUnitTest.java 049513bb3328fe842295abcd9e5f8f4135debb3b
geode-core/src/test/java/org/apache/geode/internal/cache/wan/serial/DestroyMessageTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/xmlcache/CacheTransactionManagerCreationTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/xmlcache/DefaultEntityResolver2Test.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/jta/functional/CacheJUnitTest.java 66d72d8abda1e92380ea06055b2b8d054eef5a1e
geode-core/src/test/java/org/apache/geode/internal/jta/functional/TestXACacheLoader.java 1585486c79e214c3fa89176ed60966e18760ac26
geode-core/src/test/java/org/apache/geode/internal/logging/LogServiceJUnitTest.java 5c7ccaaf145328cbfde62337954fb9152b7e4479
geode-core/src/test/java/org/apache/geode/internal/logging/log4j/AlertAppenderJUnitTest.java 571725320906f4eaa76cdf4188f7ebafb7dfc0ea
geode-core/src/test/java/org/apache/geode/internal/logging/log4j/LogWriterAppenderJUnitTest.java dbdebea37a46a2b370c55175239765b080de70ac
geode-core/src/test/java/org/apache/geode/internal/statistics/StatArchiveWriterTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/tcp/ConnectionTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/management/internal/CompositeBuilderViaFromTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/management/internal/CompositeBuilderViaProxyTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/management/internal/IdentityConverterTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/CliCommandTestBase.java f624ab427762b09645576b154b3210456f42e965
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ConfigCommandsDUnitTest.java 760d2c4c1b4cf8361b4fed22655d8356f0e3e1b5
geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/ExportedLogsSizeInfoTest.java 77a2453a6ae35d9219eb4c42032f3544c66f31ee
geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/ShowMissingDiskStoresFunctionJUnitTest.java ba436c5077d9b1fd5aa8f2dfe8de03ceb03b3c91
geode-core/src/test/java/org/apache/geode/management/internal/cli/json/TypedJsonTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/management/internal/web/controllers/WanCommandsControllerJUnitTest.java 2731b95e08c1a2693277951c7ee0aa10e8591db6
geode-core/src/test/java/org/apache/geode/management/internal/web/domain/LinkTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/management/internal/web/http/ClientHttpRequestTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/pdx/PdxSerializableDUnitTest.java 4e8a271f1d886b06d6661e3eec2a42f708e61bbd
geode-core/src/test/java/org/apache/geode/redis/internal/executor/AbstractScanExecutorTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/security/ClientAuthorizationTestCase.java 244f4e5c09ae89130d030beee838f7fb5448252d
geode-core/src/test/java/org/apache/geode/security/DeltaClientAuthorizationDUnitTest.java 9a3ce862c0fcfd016ca5f1b45a80b1d6a4ef4ced
geode-core/src/test/java/org/apache/geode/security/DeltaClientPostAuthorizationDUnitTest.java 4cc84429ce138e47766343635c51cfeb3707a9d3
geode-core/src/test/java/org/apache/geode/security/generator/AuthzCredentialGenerator.java 13d68b54121e55b76f4a4efd78cb88063973abd0
geode-core/src/test/java/org/apache/geode/security/generator/CredentialGenerator.java 8695451179dcd1900f317f9b585f94059f4d6dfb
geode-core/src/test/java/org/apache/geode/test/dunit/DUnitEnv.java 42ccf38ee9b2238efc4c443f417f32b1a6b80c84
geode-core/src/test/java/org/apache/geode/test/dunit/DistributedTestUtils.java 5b8e6158ba94255cab106e89cd1e7dd74dc4b339
geode-core/src/test/java/org/apache/geode/test/dunit/Wait.java 20fbb5bad9b42687ab025e4a57106749a4c9d51f
geode-core/src/test/java/org/apache/geode/test/dunit/tests/OverridingGetPropertiesDisconnectsAllDUnitTest.java 1d67dcde8d62e231dbf27e8e88fe9b4d7d50f8c3
geode-core/src/test/java/org/apache/geode/test/golden/FailOutputTestCase.java 71040ef4e53b0a363661197602a4c87d7fffca64
geode-core/src/test/java/org/apache/geode/test/golden/PassJUnitTest.java 2e9b8f95551c3e58729e7a2a8a94af323e13316f
geode-core/src/test/java/org/apache/geode/test/golden/PassWithExpectedProblemTestCase.java 2d60c27ec32ed91fd8d944bab8d8028f362ceaa3
geode-cq/src/test/java/org/apache/geode/internal/cache/ha/CQListGIIDUnitTest.java e979f728a94f6fb6b5ce9f9fe7b3445499d4200a
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneDUnitTest.java b80f5ded608b0abb6c99deafc5531cc6bb33f8b5
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneIndexCreationDUnitTest.java a16646ea914f9bc1c3e476c3f08e66d719f4a1f1
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneIndexCreationPersistenceIntegrationTest.java bed6f131f8447b0c771447d4914b70a25db251f9
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneIndexDestroyDUnitTest.java 67adfb9a7df68acd82c6472a5a8763a41c9ac71d
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneIndexCreationProfileJUnitTest.java 4d726391a92bf048b3adc947ed0b759e4464ac4f
geode-old-client-support/src/main/java/com/gemstone/gemfire/cache/execute/FunctionException.java d19d900a65700e81dd55c6d662f3f8a3d2276dad
geode-old-client-support/src/test/java/com/gemstone/gemfire/cache/execute/FunctionExceptionTest.java PRE-CREATION
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/WANTestBase.java f1010278a0113304c933a1ff03564f0a3b8472d8
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/support/RegionData.java ea9237e973f96c51a71a4b16305bd9c889fc22b9
geode-web-api/src/test/java/org/apache/geode/rest/internal/web/controllers/support/RegionDataTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/59386/diff/1/
Testing
-------
precheckin passed
Thanks,
Kirk Lund