[GitHub] [incubator-superset] ktmud edited a comment on issue #7425: [SIP-18] Scheduling queries from SQL Lab

[GitBox <gi...@apache.org>]

ktmud edited a comment on issue #7425:
URL: https://github.com/apache/incubator-superset/issues/7425#issuecomment-708540953


   Re: adding objects to `FEATURE_FLAGS`
   
   I think it's one thing to manage feature configs, it's another to manage whether a feature is turned on or not. If you look at LaunchDarkly's API, their feature flags are created in a very structured manner. And the information stored is only metadata about the variants, and nothing related to how the feature is implemented.
   
   It's one thing to store information about variants in features, it's another to store objects required to run the feature. I think it's dangerous and quite unscalable to blur the line here.
   
   Ideally you'd want schema/type enforcement on everything in your program, allowing people to store arbitrary stuff in FEATURE_FLAGS seems to be opposite of that direction.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org