You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by te...@apache.org on 2012/04/04 00:04:45 UTC
svn commit: r1309173 -
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java
Author: tedyu
Date: Tue Apr 3 22:04:45 2012
New Revision: 1309173
URL: http://svn.apache.org/viewvc?rev=1309173&view=rev
Log:
HBASE-5606 SplitLogManger async delete node hangs log splitting when ZK connection is lost
(Prakash)
Modified:
hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java
Modified: hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java
URL: http://svn.apache.org/viewvc/hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java?rev=1309173&r1=1309172&r2=1309173&view=diff
==============================================================================
--- hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java (original)
+++ hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java Tue Apr 3 22:04:45 2012
@@ -404,6 +404,14 @@ public class SplitLogManager extends Zoo
tot_mgr_get_data_queued.incrementAndGet();
}
+ private void tryGetDataSetWatch(String path) {
+ // A negative retry count will lead to ignoring all error processing.
+ this.watcher.getRecoverableZooKeeper().getZooKeeper().
+ getData(path, this.watcher,
+ new GetDataAsyncCallback(), new Long(-1) /* retry count */);
+ tot_mgr_get_data_queued.incrementAndGet();
+ }
+
private void getDataSetWatchSuccess(String path, byte[] data, int version) {
if (data == null) {
if (version == Integer.MIN_VALUE) {
@@ -916,11 +924,13 @@ public class SplitLogManager extends Zoo
for (Map.Entry<String, Task> e : tasks.entrySet()) {
String path = e.getKey();
Task task = e.getValue();
- // we have to do this check again because tasks might have
- // been asynchronously assigned.
- if (task.isUnassigned()) {
+ // we have to do task.isUnassigned() check again because tasks might
+ // have been asynchronously assigned. There is no locking required
+ // for these checks ... it is OK even if tryGetDataSetWatch() is
+ // called unnecessarily for a task
+ if (task.isUnassigned() && (task.status != FAILURE)) {
// We just touch the znode to make sure its still there
- getDataSetWatch(path, zkretries);
+ tryGetDataSetWatch(path);
}
}
createRescanNode(Long.MAX_VALUE);
@@ -990,6 +1000,12 @@ public class SplitLogManager extends Zoo
return;
}
Long retry_count = (Long) ctx;
+
+ if (retry_count < 0) {
+ LOG.warn("getdata rc = " + KeeperException.Code.get(rc) + " " +
+ path + ". Ignoring error. No error handling. No retrying.");
+ return;
+ }
LOG.warn("getdata rc = " + KeeperException.Code.get(rc) + " " +
path + " remaining retries=" + retry_count);
if (retry_count == 0) {