You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "wu-sheng (via GitHub)" <gi...@apache.org> on 2026/08/06 07:28:35 UTC

[PR] test(e2e): make the metric aggregation-mode spec fail without the fix [skywalking-horizon-ui]

wu-sheng opened a new pull request, #114:
URL: https://github.com/apache/skywalking-horizon-ui/pull/114

   Follow-up to #113, addressing [this review comment](https://github.com/apache/skywalking-horizon-ui/pull/113#discussion_r3722445221).
   
   ## The problem
   
   The aggregation-mode spec opened whichever widget came **first** on the bundled Services Dashboard — a `kpi-tile`, which has always carried the mode control — and then asserted the radios existed. So it asserted nothing about `metric`, and passed against a build where the control was still withheld from that type.
   
   That is not hypothetical: it passed in the #113 runs *before* the e2e image was rebuilt, i.e. against the unfixed UI. I read that as reassurance at the time. A guard that passes without the fix guards nothing.
   
   ## The fix
   
   - **adds** a metric widget through the composer (asserting `metric` really is the default type) instead of opening whatever is first
   - scopes the assertions to `.ot__widget--metric`, the drawer's per-type modifier, with a failure message that says the drawer is not showing a metric
   - requires **exactly two** mode radios in that panel
   - covers the other half of #113 that nothing asserted: the **Aggregation** select is absent in server-side mode, where it is never read, and appears once page-side is chosen
   
   ## Verified in both directions
   
   | build | result |
   | --- | --- |
   | pre-fix drawer (`a6cb441~1`), image rebuilt from it | **9 passed / 1 failed** — `Expected: 2, Received: 0` (no mode radios on a metric widget) |
   | current `main` | **10 passed / 0 failed** |
   
   The negative control is the point of this PR: the previous spec passed in both directions.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test(e2e): make the metric aggregation-mode spec fail without the fix [skywalking-horizon-ui]

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #114:
URL: https://github.com/apache/skywalking-horizon-ui/pull/114


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org