[GitHub] [superset] adam-stasiak edited a comment on pull request #12773: chore: Tab title to be empty when creating a new tab

[GitBox <gi...@apache.org>]

adam-stasiak edited a comment on pull request #12773:
URL: https://github.com/apache/superset/pull/12773#issuecomment-768468701


   We discussed behavior with @junlincc and some tweaks are needed:
   - placeholder should be 'Tab title'
   - when we add another tab we should switch to new tab in edit mode - that means user does not have to click anything to start typing - according to: ```Clicking the plus button should bring you into an empty input with "Tab title" as placeholder text, so you can start typing immediately.```
   @mihir174 Could you think about this and confirm it is the thing we want. In other place in our application (SQL editor) when we add a new tab we are not in edition mode - but it is a little bit different case. While editing dashboard I assume we want to name our tab when we add this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org