You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/08/15 20:15:10 UTC

[GitHub] [incubator-druid] himanshug opened a new pull request #8319: string column handling for long/float min/max/sum aggregators

himanshug opened a new pull request #8319: string column handling for long/float min/max/sum aggregators
URL: https://github.com/apache/incubator-druid/pull/8319
 
 
   Fixes #8148 
   
   Same as #8243 but for long/float min/max/sum aggregators
   
   ### Description
   This patch adds handling of single/multi value column handling by long/float sum/min/max aggregators to do a best effort parsing string as long/float.
   
   `StringColumn[Long/Float]AggregatorWrapper` and `StringColumn[Long/Float]BufferAggregatorWrapper` classes are introduced that can wrap existing long/float aggregators to handle string columns. Both of the classes are used by `Simple[Long/Float]AggregatorFactory` to be used when input column is known to be of String type.
   
   <hr>
   
   This PR has:
   - [x] been self-reviewed.
   - [x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
   - [x] added unit tests or modified existing tests to cover new code paths.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org