You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2016/01/13 23:02:32 UTC
Re: Review Request 42052: Refactored Subprocess::IO into an abstract
type.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42052/
-----------------------------------------------------------
(Updated Jan. 13, 2016, 2:02 p.m.)
Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
Changes
-------
Applied BenH's changes (discussed offline) and polished it up.
Summary (updated)
-----------------
Refactored Subprocess::IO into an abstract type.
Bugs: MESOS-4136
https://issues.apache.org/jira/browse/MESOS-4136
Repository: mesos
Description (updated)
-------
Subprocess::PATH/FD/PIPE are changed from static helpers to subclasses.
Replaced `int pipefd[2]` with the structs `InputFileDescriptors` and `OutputFileDescriptors`.
Slight cleanup of Subprocess code.
Diffs (updated)
-----
3rdparty/libprocess/include/process/subprocess.hpp 8704cd0a8af92b848eb9ff7cffe8e5251c5dcfec
3rdparty/libprocess/src/subprocess.cpp 863523404b9ef1d2024c108f3e9e1c77c3916049
Diff: https://reviews.apache.org/r/42052/diff/
Testing
-------
make check (next review)
Thanks,
Joseph Wu
Re: Review Request 42052: Refactored Subprocess::IO to improve
readability.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42052/#review114404
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On Jan. 14, 2016, 1:55 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42052/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2016, 1:55 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
>
>
> Bugs: MESOS-4136
> https://issues.apache.org/jira/browse/MESOS-4136
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replaced `int pipefd[2]` with the structs `InputFileDescriptors` and `OutputFileDescriptors`.
> Replaced the `switch` statements inside `process::subprocess` with lambdas defined in the static helpers (`PIPE`, `PATH`, `FD`).
>
> Slight cleanup of Subprocess code.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/subprocess.hpp 8704cd0a8af92b848eb9ff7cffe8e5251c5dcfec
> 3rdparty/libprocess/src/subprocess.cpp 863523404b9ef1d2024c108f3e9e1c77c3916049
>
> Diff: https://reviews.apache.org/r/42052/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 42052: Refactored Subprocess::IO to improve
readability.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42052/
-----------------------------------------------------------
(Updated Jan. 13, 2016, 5:55 p.m.)
Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
Changes
-------
Got rid of the abstract type, in favor of Lambdas!!
Summary (updated)
-----------------
Refactored Subprocess::IO to improve readability.
Bugs: MESOS-4136
https://issues.apache.org/jira/browse/MESOS-4136
Repository: mesos
Description (updated)
-------
Replaced `int pipefd[2]` with the structs `InputFileDescriptors` and `OutputFileDescriptors`.
Replaced the `switch` statements inside `process::subprocess` with lambdas defined in the static helpers (`PIPE`, `PATH`, `FD`).
Slight cleanup of Subprocess code.
Diffs (updated)
-----
3rdparty/libprocess/include/process/subprocess.hpp 8704cd0a8af92b848eb9ff7cffe8e5251c5dcfec
3rdparty/libprocess/src/subprocess.cpp 863523404b9ef1d2024c108f3e9e1c77c3916049
Diff: https://reviews.apache.org/r/42052/diff/
Testing (updated)
-------
make check
Thanks,
Joseph Wu