[trafficserver] branch 9.1.x updated: Allows errors from plugin initialization to bubble up (#8926)

[bc...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

bcall pushed a commit to branch 9.1.x
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/9.1.x by this push:
     new aad598908 Allows errors from plugin initialization to bubble up (#8926)
aad598908 is described below

commit aad5989087922c5f082be96097f6f4f68b93b385
Author: Randall Meyer <rr...@apache.org>
AuthorDate: Mon Jun 27 11:16:34 2022 -0700

    Allows errors from plugin initialization to bubble up (#8926)
    
    Prior to this change, if plugin initialization fails, the error message from plugin init
    would get cleared when trying to unload the DSO.
    
    (cherry picked from commit 6ee1c6b27893262b3aa12d176cdc86a165b64b4c)
---
 proxy/http/remap/PluginDso.cc | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/proxy/http/remap/PluginDso.cc b/proxy/http/remap/PluginDso.cc
index d4467b8ce..eb600a5f0 100644
--- a/proxy/http/remap/PluginDso.cc
+++ b/proxy/http/remap/PluginDso.cc
@@ -125,8 +125,6 @@ PluginDso::load(std::string &error)
 bool
 PluginDso::unload(std::string &error)
 {
-  /* clean errors */
-  error.clear();
   bool result = false;
 
   if (isLoaded()) {
@@ -158,7 +156,6 @@ PluginDso::getSymbol(const char *symbol, void *&address, std::string &error) con
 {
   /* Clear the errors */
   dlerror();
-  error.clear();
 
   address   = dlsym(_dlh, symbol);
   char *err = dlerror();