You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/07/23 09:38:06 UTC

[GitHub] [rocketmq] horizonzy opened a new issue #2194: the judgement logic worng in org.apache.rocketmq.common.MixAll#string2FileNotSafe

horizonzy opened a new issue #2194:
URL: https://github.com/apache/rocketmq/issues/2194


   **BUG REPORT**
   
   1. Please describe the issue you observed:
   the judgement logic of  fileParent.mkdirs() is wrong.
   in org.apache.rocketmq.common.MixAll#string2FileNotSafe.
   the code is: 
   ```
    if (fileParent != null) {
               fileParent.mkdirs();
        }
   ```
   
   maybe it should change to 
   ```
     if (fileParent == null) {
               fileParent.mkdirs();
           }
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] RongtongJin closed issue #2194: the judgement logic worng in org.apache.rocketmq.common.MixAll#string2FileNotSafe

Posted by GitBox <gi...@apache.org>.
RongtongJin closed issue #2194:
URL: https://github.com/apache/rocketmq/issues/2194


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org