You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "lancelly (via GitHub)" <gi...@apache.org> on 2023/08/01 10:11:13 UTC
[GitHub] [shardingsphere] lancelly opened a new pull request, #27614: [Oracle SQL] Support OE-4-6/OE-4-7/OE-4-8 of Oracle SQL
lancelly opened a new pull request, #27614:
URL: https://github.com/apache/shardingsphere/pull/27614
In this pr, I supported parsing of the following SQLs:
``` SELECT customer_id, cust_address_ntab MULTISET EXCEPT DISTINCT cust_address2_ntab multiset_except FROM customers_demo ORDER BY customer_id;```
``` SELECT customer_id, cust_address_ntab MULTISET INTERSECT DISTINCT cust_address2_ntab multiset_intersect FROM customers_demo ORDER BY customer_id;```
```SELECT customer_id, cust_address_ntab MULTISET UNION cust_address2_ntab multiset_union FROM customers_demo ORDER BY customer_id;```
Reference could be found at: https://docs.oracle.com/cd/B13789_01/server.101/b10759/operators006.htm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on a diff in pull request #27614: [Oracle SQL] Support OE-4-6/OE-4-7/OE-4-8 of Oracle SQL
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang commented on code in PR #27614:
URL: https://github.com/apache/shardingsphere/pull/27614#discussion_r1280477492
##########
parser/sql/dialect/oracle/src/main/antlr4/imports/oracle/BaseRule.g4:
##########
@@ -1984,3 +1985,13 @@ xmlTableOptions
xmlTableColumn
: columnName (FOR ORDINALITY | (dataType | XMLTYPE (LP_ SEQUENCE RP_ BY REF)?) (PATH STRING_)? (DEFAULT expr)?)
;
+
+multisetExpr
+ : columnName MULTISET multisetOperator (ALL | DISTINCT)? columnName
+ ;
+
+multisetOperator
+ : EXCEPT
+ | INTERSECT
+ | UNION
+ ;
Review Comment:
Hi @lancelly , please keep a blank line at the end of file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #27614: [Oracle SQL] Support OE-4-6/OE-4-7/OE-4-8 of Oracle SQL
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang merged PR #27614:
URL: https://github.com/apache/shardingsphere/pull/27614
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on pull request #27614: [Oracle SQL] Support OE-4-6/OE-4-7/OE-4-8 of Oracle SQL
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang commented on PR #27614:
URL: https://github.com/apache/shardingsphere/pull/27614#issuecomment-1661435332
For #27569.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] lancelly commented on a diff in pull request #27614: [Oracle SQL] Support OE-4-6/OE-4-7/OE-4-8 of Oracle SQL
Posted by "lancelly (via GitHub)" <gi...@apache.org>.
lancelly commented on code in PR #27614:
URL: https://github.com/apache/shardingsphere/pull/27614#discussion_r1280592716
##########
parser/sql/dialect/oracle/src/main/antlr4/imports/oracle/BaseRule.g4:
##########
@@ -1984,3 +1985,13 @@ xmlTableOptions
xmlTableColumn
: columnName (FOR ORDINALITY | (dataType | XMLTYPE (LP_ SEQUENCE RP_ BY REF)?) (PATH STRING_)? (DEFAULT expr)?)
;
+
+multisetExpr
+ : columnName MULTISET multisetOperator (ALL | DISTINCT)? columnName
+ ;
+
+multisetOperator
+ : EXCEPT
+ | INTERSECT
+ | UNION
+ ;
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org