[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1290: MINIFICPP-1789 - Log checking is wrong in integration tests

[GitBox <gi...@apache.org>]

fgerlits commented on a change in pull request #1290:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1290#discussion_r838256327



##########
File path: docker/test/integration/MiNiFi_integration_test_driver.py
##########
@@ -248,7 +248,7 @@ def check_query_results(self, postgresql_container_name, query, number_of_rows,
         assert self.cluster.check_query_results(postgresql_container_name, query, number_of_rows, timeout_seconds)
 
     def wait_for_container_logs(self, container_name, log_pattern, timeout_seconds, count=1):
-        self.cluster.wait_for_app_logs_regex(container_name, log_pattern, timeout_seconds, count)
+        assert self.cluster.wait_for_app_logs_regex(container_name, log_pattern, timeout_seconds, count)

Review comment:
       Good catch!
   
   I would rename this function to `check_container_log_matches_regex`, as it does more than just wait for the logs.  Also, it is the more general pair of `check_minifi_log_matches_regex`, similarly to the pair of functions `check_minifi_log_contents` and `check_container_log_contents`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org