[GitHub] [netbeans] matthiasblaesing commented on pull request #2656: [NETBEANS-5195] Change icon for JSON files

[GitBox <gi...@apache.org>]

matthiasblaesing commented on pull request #2656:
URL: https://github.com/apache/netbeans/pull/2656#issuecomment-757357481


   Looks ok to me - three questions/requests:
   
   - [ ] You understand, that you are donating this changeset to the ASF, which is then free to do with it as it sees fit (see the comment of the source files for the longer version). TL;DR: If the ASF ever decides to relicense the code it will treat this code as if it was the owner of it.
   - [ ] Would it be possible to add an SVG version of the icon? There was some work done to convert older icons to svg, it would be great if new additions would directly be present in png and svg versions.
   - [ ] As the PNG can't hold a license header, please add an entry to  https://github.com/apache/netbeans/blob/96bbee4b557e6ef99645bd7a5c0de6e2554f0f3d/webcommon/javascript2.editor/licenseinfo.xml (see https://github.com/apache/netbeans/blob/master/ide/git/licenseinfo.xml as reference). That way the license check can pick up the license information. If an SVG added, the license information should be in the XML, as it supports comments.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists