You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/09/05 19:22:20 UTC

[jira] [Commented] (BEAM-544) Add header/footer support to TextIO.Write

    [ https://issues.apache.org/jira/browse/BEAM-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465632#comment-15465632 ] 

ASF GitHub Bot commented on BEAM-544:
-------------------------------------

GitHub user staslev opened a pull request:

    https://github.com/apache/incubator-beam/pull/918

    [BEAM-544] Add header/footer support to TextIO.Write

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    R: @lukecwik 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/staslev/incubator-beam BEAM-544

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/918.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #918
    
----
commit df64df61963831f16050eb3078ddcf9ffe65c76e
Author: Stas Levin <st...@gmail.com>
Date:   2016-09-05T17:26:12Z

    Add header/footer support to TextIO.Write

----


> Add header/footer support to TextIO.Write
> -----------------------------------------
>
>                 Key: BEAM-544
>                 URL: https://issues.apache.org/jira/browse/BEAM-544
>             Project: Beam
>          Issue Type: New Feature
>          Components: sdk-java-extensions
>            Reporter: Luke Cwik
>            Priority: Minor
>
> Being able to add a header/footer to each file that is written via TextIO would cover several simple text file format issues.
> Original ask:
> https://github.com/GoogleCloudPlatform/DataflowJavaSDK/issues/360



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)