You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/12/16 19:40:22 UTC
[GitHub] [tvm] shingjan opened a new pull request #9758: [TVMScript][FIX] Fix number of arguments for T.Buffer[...]
shingjan opened a new pull request #9758:
URL: https://github.com/apache/tvm/pull/9758
This PR intends to fix the number of arguments for `T.Buffer[]` and raise an error if the first argument of it is not a `tuple`.
cc: @vinx13 @junrushao1994
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi merged pull request #9758: [TVMScript][FIX] Fix number of arguments for T.Buffer[...]
Posted by GitBox <gi...@apache.org>.
masahi merged pull request #9758:
URL: https://github.com/apache/tvm/pull/9758
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] vinx13 commented on a change in pull request #9758: [TVMScript][FIX] Fix number of arguments for T.Buffer[...]
Posted by GitBox <gi...@apache.org>.
vinx13 commented on a change in pull request #9758:
URL: https://github.com/apache/tvm/pull/9758#discussion_r770940774
##########
File path: tests/python/unittest/test_tvmscript_syntax_sugar.py
##########
@@ -146,5 +146,16 @@ def test_match_buffer_syntax_sugar():
assert_structural_equal(elementwise_handle, elementwise_buffer_no_kwargs)
+# match buffer failed case
+def test_match_buffer_no_kwargs_failed():
+ with pytest.raises(ValueError) as e:
+
+ def elementwise_buffer_no_kwargs_failed(
Review comment:
```suggestion
@T.prim_func
def elementwise_buffer_no_kwargs_failed(
```
we'd like to make the test case as close to real use case as possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org