You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2020/04/30 12:56:00 UTC
[GitHub] [qpid-dispatch] kgiusti opened a new pull request #730: DISPATCH-1636: extract the peer router's version from the Open frame
kgiusti opened a new pull request #730:
URL: https://github.com/apache/qpid-dispatch/pull/730
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy commented on a change in pull request #730: DISPATCH-1636: extract the peer router's version from the Open frame
Posted by GitBox <gi...@apache.org>.
ganeshmurthy commented on a change in pull request #730:
URL: https://github.com/apache/qpid-dispatch/pull/730#discussion_r421044139
##########
File path: include/qpid/dispatch/router_core.h
##########
@@ -851,6 +851,30 @@ void qdr_query_free(qdr_query_t *query);
typedef void (*qdr_manage_response_t) (void *context, const qd_amqp_error_t *status, bool more);
void qdr_manage_handler(qdr_core_t *core, qdr_manage_response_t response_handler);
+typedef struct {
+ uint16_t major;
+ uint16_t minor;
+ uint16_t patch;
+ uint16_t flags;
+#define QDR_ROUTER_VERSION_SNAPSHOT 0x0100
+#define QDR_ROUTER_VERSION_RC 0x0200 // lower byte == RC #
Review comment:
Are these used in the code anywhere?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy commented on a change in pull request #730: DISPATCH-1636: extract the peer router's version from the Open frame
Posted by GitBox <gi...@apache.org>.
ganeshmurthy commented on a change in pull request #730:
URL: https://github.com/apache/qpid-dispatch/pull/730#discussion_r421028220
##########
File path: tests/system_tests_edge_router.py
##########
@@ -1640,6 +1640,51 @@ def _test_traffic(self, sender, receiver, address, count=5):
tr.queue.get(timeout=TIMEOUT)
tr.stop()
+ def test_000_check_peer_version_info(self):
+ """
+ Not a link proxy test - ensure router correctly parses peer version
+ numbers advertised in the incoming @open frame
+ """
+ lines = None
+ with open("../setUpClass/INT.A.log") as inta_log:
Review comment:
Can we use with open(self.router.outdir + '/INT.A.log, 'r') as inta_log:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #730: DISPATCH-1636: extract the peer router's version from the Open frame
Posted by GitBox <gi...@apache.org>.
kgiusti commented on a change in pull request #730:
URL: https://github.com/apache/qpid-dispatch/pull/730#discussion_r421044181
##########
File path: tests/system_tests_edge_router.py
##########
@@ -1640,6 +1640,51 @@ def _test_traffic(self, sender, receiver, address, count=5):
tr.queue.get(timeout=TIMEOUT)
tr.stop()
+ def test_000_check_peer_version_info(self):
+ """
+ Not a link proxy test - ensure router correctly parses peer version
+ numbers advertised in the incoming @open frame
+ """
+ lines = None
+ with open("../setUpClass/INT.A.log") as inta_log:
Review comment:
Ah - good catch, thanks! (fixed)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on pull request #730: DISPATCH-1636: extract the peer router's version from the Open frame
Posted by GitBox <gi...@apache.org>.
kgiusti commented on pull request #730:
URL: https://github.com/apache/qpid-dispatch/pull/730#issuecomment-621896353
I'll add a couple of version test comparison macros && tests...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #730: DISPATCH-1636: extract the peer router's version from the Open frame
Posted by GitBox <gi...@apache.org>.
kgiusti commented on a change in pull request #730:
URL: https://github.com/apache/qpid-dispatch/pull/730#discussion_r421551362
##########
File path: include/qpid/dispatch/router_core.h
##########
@@ -851,6 +851,30 @@ void qdr_query_free(qdr_query_t *query);
typedef void (*qdr_manage_response_t) (void *context, const qd_amqp_error_t *status, bool more);
void qdr_manage_handler(qdr_core_t *core, qdr_manage_response_t response_handler);
+typedef struct {
+ uint16_t major;
+ uint16_t minor;
+ uint16_t patch;
+ uint16_t flags;
+#define QDR_ROUTER_VERSION_SNAPSHOT 0x0100
+#define QDR_ROUTER_VERSION_RC 0x0200 // lower byte == RC #
Review comment:
Nope - not yet. Reserved. Since we _do_ use a snapshot (dev builds), I wanted to add an additional flag to the version, which - since it's 2 bytes - aligns the version structure to a nice round 8 bytes and gives us a few extra bits to support RC numbers if we ever choose to do so in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org