You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by huor <gi...@git.apache.org> on 2017/02/10 05:35:21 UTC
[GitHub] incubator-hawq pull request #1112: HAWQ-1319. Add ASF header to java files a...
GitHub user huor opened a pull request:
https://github.com/apache/incubator-hawq/pull/1112
HAWQ-1319. Add ASF header to java files and remove jar files in function suite
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/huor/incubator-hawq huor_java
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/1112.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1112
----
commit cae278da16c96f7ed34cf91ab199e758b4d0b020
Author: Ruilong Huo <rh...@pivotal.io>
Date: 2017-02-10T05:34:21Z
HAWQ-1319. Add ASF header to java files and remove jar files in function suite
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1112: HAWQ-1319. Add ASF header to java files a...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1112#discussion_r100474652
--- Diff: src/test/feature/UDF/TestUDF.cpp ---
@@ -200,6 +218,10 @@ TEST_F(TestUDF, TestUDFPljava)
// run test if pljava language is enabled
if (util.getQueryResult("SELECT lanname FROM pg_language WHERE lanname = 'java'") == "java")
{
+ // prepare jar files
+ hawq::test::Command cmd("cd " + d_feature_test_root + "/UDF/sql/; javac PLJavaAdd.java; jar cf PLJavaAdd.jar PLJavaAdd.class");
+ cmd.run();
+
--- End diff --
java is dependency for hawq as well, it is checked by configure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1112: HAWQ-1319. Add ASF header to java files a...
Posted by huor <gi...@git.apache.org>.
Github user huor closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1112
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1112: HAWQ-1319. Add ASF header to java files and remo...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on the issue:
https://github.com/apache/incubator-hawq/pull/1112
@edespino and @paul-guo-, please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1112: HAWQ-1319. Add ASF header to java files a...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1112#discussion_r100474228
--- Diff: src/test/feature/UDF/TestUDF.cpp ---
@@ -200,6 +218,10 @@ TEST_F(TestUDF, TestUDFPljava)
// run test if pljava language is enabled
if (util.getQueryResult("SELECT lanname FROM pg_language WHERE lanname = 'java'") == "java")
{
+ // prepare jar files
+ hawq::test::Command cmd("cd " + d_feature_test_root + "/UDF/sql/; javac PLJavaAdd.java; jar cf PLJavaAdd.jar PLJavaAdd.class");
+ cmd.run();
+
--- End diff --
I'm wondering we should add a chapter in README.md for requirement, e.g. we need java dev package for test running here. Others look good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---