You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Andrew Purtell (JIRA)" <ji...@apache.org> on 2011/06/30 19:46:30 UTC
[jira] [Created] (HBASE-4048) [Coprocessors] Support configuration
of coprocessor at load time
[Coprocessors] Support configuration of coprocessor at load time
----------------------------------------------------------------
Key: HBASE-4048
URL: https://issues.apache.org/jira/browse/HBASE-4048
Project: HBase
Issue Type: Improvement
Reporter: Andrew Purtell
Assignee: Andrew Purtell
Fix For: 0.92.0
Users should be able to pass configuration options to coprocessors. These options should be applied at load time.
- For system coprocessors, just use the configuration of the container.
- Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value>{,}).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4048) [Coprocessors] Support
configuration of coprocessor at load time
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058080#comment-13058080 ]
jiraposter@reviews.apache.org commented on HBASE-4048:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/984/
-----------------------------------------------------------
Review request for hbase.
Summary
-------
Users should be able to pass configuration options to coprocessors. These options should be applied at load time.
- For system coprocessors, just use the configuration of the container.
- Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value>{,}).
This addresses bug HBASE-4048.
https://issues.apache.org/jira/browse/HBASE-4048
Diffs
-----
src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java c2ea442
src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java ac5387a
src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 5bae05a
src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java 4800bea
src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java a98117f
src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java 796742c
src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java 58a09f8
src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java 969b1f3
src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java 0cdf7d1
Diff: https://reviews.apache.org/r/984/diff
Testing
-------
Modified o.a.h.h.coprocessor.TestClassLoading to check new functionality.
Thanks,
Andrew
> [Coprocessors] Support configuration of coprocessor at load time
> ----------------------------------------------------------------
>
> Key: HBASE-4048
> URL: https://issues.apache.org/jira/browse/HBASE-4048
> Project: HBase
> Issue Type: Improvement
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Fix For: 0.92.0
>
>
> Users should be able to pass configuration options to coprocessors. These options should be applied at load time.
> - For system coprocessors, just use the configuration of the container.
> - Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value>{,}).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4048) [Coprocessors] Support
configuration of coprocessor at load time
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058247#comment-13058247 ]
jiraposter@reviews.apache.org commented on HBASE-4048:
------------------------------------------------------
bq. On 2011-07-01 01:28:44, Ted Yu wrote:
bq. > src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java, line 31
bq. > <https://reviews.apache.org/r/984/diff/1/?file=21839#file21839line31>
bq. >
bq. > Here they're not declared final.
bq. >
bq. > I guess the reason of retaining Priority was for compatibility so that Coprocessor.Priority.USER, etc in user code would compile.
bq. >
bq. > Since 0.92 hasn't been released, we don't need to be bounded by the above.
bq. >
bq. > Maybe there was other reason.
bq. I guess the reason of retaining Priority was for compatibility so that Coprocessor.Priority.USER, etc in user code would compile.
This does not make sense to be bound by such considerations until release.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/984/#review943
-----------------------------------------------------------
On 2011-06-30 21:16:28, Andrew Purtell wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/984/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-06-30 21:16:28)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Users should be able to pass configuration options to coprocessors. These options should be applied at load time.
bq.
bq. - For system coprocessors, just use the configuration of the container.
bq.
bq. - Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value>{,}).
bq.
bq. Also fixes the outstanding issue where coprocessor priority is supposed to be an integer range but is constrained by the Coprocessor.Priority enum to 4 values.
bq.
bq.
bq. This addresses bug HBASE-4048.
bq. https://issues.apache.org/jira/browse/HBASE-4048
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java c2ea442
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java ac5387a
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 5bae05a
bq. src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java 4800bea
bq. src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java a98117f
bq. src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java 796742c
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java 58a09f8
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java 969b1f3
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java 0cdf7d1
bq.
bq. Diff: https://reviews.apache.org/r/984/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Modified o.a.h.h.coprocessor.TestClassLoading to check new functionality.
bq.
bq.
bq. Thanks,
bq.
bq. Andrew
bq.
bq.
> [Coprocessors] Support configuration of coprocessor at load time
> ----------------------------------------------------------------
>
> Key: HBASE-4048
> URL: https://issues.apache.org/jira/browse/HBASE-4048
> Project: HBase
> Issue Type: Improvement
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Fix For: 0.92.0
>
> Attachments: HBASE-4048.patch
>
>
> Users should be able to pass configuration options to coprocessors. These options should be applied at load time.
> - For system coprocessors, just use the configuration of the container.
> - Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value>{,}).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4048) [Coprocessors] Support
configuration of coprocessor at load time
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058099#comment-13058099 ]
jiraposter@reviews.apache.org commented on HBASE-4048:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/984/#review936
-----------------------------------------------------------
src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java
<https://reviews.apache.org/r/984/#comment2013>
Would an abstract class be more appropriate here ?
src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java
<https://reviews.apache.org/r/984/#comment2012>
White space.
- Ted
On 2011-06-30 21:16:28, Andrew Purtell wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/984/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-06-30 21:16:28)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Users should be able to pass configuration options to coprocessors. These options should be applied at load time.
bq.
bq. - For system coprocessors, just use the configuration of the container.
bq.
bq. - Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value>{,}).
bq.
bq. Also fixes the outstanding issue where coprocessor priority is supposed to be an integer range but is constrained by the Coprocessor.Priority enum to 4 values.
bq.
bq.
bq. This addresses bug HBASE-4048.
bq. https://issues.apache.org/jira/browse/HBASE-4048
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java c2ea442
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java ac5387a
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 5bae05a
bq. src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java 4800bea
bq. src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java a98117f
bq. src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java 796742c
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java 58a09f8
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java 969b1f3
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java 0cdf7d1
bq.
bq. Diff: https://reviews.apache.org/r/984/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Modified o.a.h.h.coprocessor.TestClassLoading to check new functionality.
bq.
bq.
bq. Thanks,
bq.
bq. Andrew
bq.
bq.
> [Coprocessors] Support configuration of coprocessor at load time
> ----------------------------------------------------------------
>
> Key: HBASE-4048
> URL: https://issues.apache.org/jira/browse/HBASE-4048
> Project: HBase
> Issue Type: Improvement
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Fix For: 0.92.0
>
> Attachments: HBASE-4048.patch
>
>
> Users should be able to pass configuration options to coprocessors. These options should be applied at load time.
> - For system coprocessors, just use the configuration of the container.
> - Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value>{,}).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4048) [Coprocessors] Support
configuration of coprocessor at load time
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058662#comment-13058662 ]
jiraposter@reviews.apache.org commented on HBASE-4048:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/984/#review953
-----------------------------------------------------------
Ship it!
- Ted
On 2011-07-01 17:19:11, Andrew Purtell wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/984/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-07-01 17:19:11)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Users should be able to pass configuration options to coprocessors. These options should be applied at load time.
bq.
bq. - For system coprocessors, just use the configuration of the container.
bq.
bq. - Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value>{,}).
bq.
bq. Also fixes the outstanding issue where coprocessor priority is supposed to be an integer range but is constrained by the Coprocessor.Priority enum to 4 values.
bq.
bq.
bq. This addresses bug HBASE-4048.
bq. https://issues.apache.org/jira/browse/HBASE-4048
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java c2ea442
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java ac5387a
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 5bae05a
bq. src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java 4800bea
bq. src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java 9c4916f
bq. src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java 796742c
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java 58a09f8
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java 969b1f3
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverInterface.java 0435326
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java 0cdf7d1
bq.
bq. Diff: https://reviews.apache.org/r/984/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Modified o.a.h.h.coprocessor.TestClassLoading to check new functionality.
bq.
bq.
bq. Thanks,
bq.
bq. Andrew
bq.
bq.
> [Coprocessors] Support configuration of coprocessor at load time
> ----------------------------------------------------------------
>
> Key: HBASE-4048
> URL: https://issues.apache.org/jira/browse/HBASE-4048
> Project: HBase
> Issue Type: Improvement
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Fix For: 0.92.0
>
> Attachments: HBASE-4048.patch
>
>
> Users should be able to pass configuration options to coprocessors. These options should be applied at load time.
> - For system coprocessors, just use the configuration of the container.
> - Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value>{,}).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4048) [Coprocessors] Support
configuration of coprocessor at load time
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058175#comment-13058175 ]
jiraposter@reviews.apache.org commented on HBASE-4048:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/984/#review943
-----------------------------------------------------------
src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java
<https://reviews.apache.org/r/984/#comment2019>
Here they're not declared final.
I guess the reason of retaining Priority was for compatibility so that Coprocessor.Priority.USER, etc in user code would compile.
Since 0.92 hasn't been released, we don't need to be bounded by the above.
Maybe there was other reason.
- Ted
On 2011-06-30 21:16:28, Andrew Purtell wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/984/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-06-30 21:16:28)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Users should be able to pass configuration options to coprocessors. These options should be applied at load time.
bq.
bq. - For system coprocessors, just use the configuration of the container.
bq.
bq. - Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value>{,}).
bq.
bq. Also fixes the outstanding issue where coprocessor priority is supposed to be an integer range but is constrained by the Coprocessor.Priority enum to 4 values.
bq.
bq.
bq. This addresses bug HBASE-4048.
bq. https://issues.apache.org/jira/browse/HBASE-4048
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java c2ea442
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java ac5387a
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 5bae05a
bq. src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java 4800bea
bq. src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java a98117f
bq. src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java 796742c
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java 58a09f8
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java 969b1f3
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java 0cdf7d1
bq.
bq. Diff: https://reviews.apache.org/r/984/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Modified o.a.h.h.coprocessor.TestClassLoading to check new functionality.
bq.
bq.
bq. Thanks,
bq.
bq. Andrew
bq.
bq.
> [Coprocessors] Support configuration of coprocessor at load time
> ----------------------------------------------------------------
>
> Key: HBASE-4048
> URL: https://issues.apache.org/jira/browse/HBASE-4048
> Project: HBase
> Issue Type: Improvement
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Fix For: 0.92.0
>
> Attachments: HBASE-4048.patch
>
>
> Users should be able to pass configuration options to coprocessors. These options should be applied at load time.
> - For system coprocessors, just use the configuration of the container.
> - Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value>{,}).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4048) [Coprocessors] Support configuration
of coprocessor at load time
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Purtell updated HBASE-4048:
----------------------------------
Status: Patch Available (was: Open)
> [Coprocessors] Support configuration of coprocessor at load time
> ----------------------------------------------------------------
>
> Key: HBASE-4048
> URL: https://issues.apache.org/jira/browse/HBASE-4048
> Project: HBase
> Issue Type: Improvement
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Fix For: 0.92.0
>
> Attachments: HBASE-4048.patch
>
>
> Users should be able to pass configuration options to coprocessors. These options should be applied at load time.
> - For system coprocessors, just use the configuration of the container.
> - Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value>{,}).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4048) [Coprocessors] Support
configuration of coprocessor at load time
Posted by "Jason Rutherglen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13066540#comment-13066540 ]
Jason Rutherglen commented on HBASE-4048:
-----------------------------------------
Is there documentation on how to use this API? It looks like the main entry point is represented in this sample code?
{code}
htd.setValue("COPROCESSOR$2", jarFileOnHDFS2.toString() + "|" + cpName2 +
+"|" + Coprocessor.PRIORITY_USER + "|k1=v1,k2=v2,k3=v3");
{code}
Where pipe is used as a separator? Looks like pipe is required?
> [Coprocessors] Support configuration of coprocessor at load time
> ----------------------------------------------------------------
>
> Key: HBASE-4048
> URL: https://issues.apache.org/jira/browse/HBASE-4048
> Project: HBase
> Issue Type: Improvement
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Fix For: 0.92.0
>
> Attachments: HBASE-4048.patch, HBASE-4048.patch
>
>
> Users should be able to pass configuration options to coprocessors. These options should be applied at load time.
> - For system coprocessors, just use the configuration of the container.
> - Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value>{,}).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4048) [Coprocessors] Support configuration
of coprocessor at load time
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Purtell updated HBASE-4048:
----------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Committed. Thanks for the reviews Ted.
> [Coprocessors] Support configuration of coprocessor at load time
> ----------------------------------------------------------------
>
> Key: HBASE-4048
> URL: https://issues.apache.org/jira/browse/HBASE-4048
> Project: HBase
> Issue Type: Improvement
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Fix For: 0.92.0
>
> Attachments: HBASE-4048.patch, HBASE-4048.patch
>
>
> Users should be able to pass configuration options to coprocessors. These options should be applied at load time.
> - For system coprocessors, just use the configuration of the container.
> - Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value>{,}).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4048) [Coprocessors] Support
configuration of coprocessor at load time
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058659#comment-13058659 ]
jiraposter@reviews.apache.org commented on HBASE-4048:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/984/
-----------------------------------------------------------
(Updated 2011-07-01 17:19:11.368248)
Review request for hbase.
Changes
-------
Lift the four Priority constants to Coprocessor.
Clean up extraneous whitespace.
Summary
-------
Users should be able to pass configuration options to coprocessors. These options should be applied at load time.
- For system coprocessors, just use the configuration of the container.
- Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value>{,}).
Also fixes the outstanding issue where coprocessor priority is supposed to be an integer range but is constrained by the Coprocessor.Priority enum to 4 values.
This addresses bug HBASE-4048.
https://issues.apache.org/jira/browse/HBASE-4048
Diffs (updated)
-----
src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java c2ea442
src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java ac5387a
src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 5bae05a
src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java 4800bea
src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java 9c4916f
src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java 796742c
src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java 58a09f8
src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java 969b1f3
src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverInterface.java 0435326
src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java 0cdf7d1
Diff: https://reviews.apache.org/r/984/diff
Testing
-------
Modified o.a.h.h.coprocessor.TestClassLoading to check new functionality.
Thanks,
Andrew
> [Coprocessors] Support configuration of coprocessor at load time
> ----------------------------------------------------------------
>
> Key: HBASE-4048
> URL: https://issues.apache.org/jira/browse/HBASE-4048
> Project: HBase
> Issue Type: Improvement
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Fix For: 0.92.0
>
> Attachments: HBASE-4048.patch
>
>
> Users should be able to pass configuration options to coprocessors. These options should be applied at load time.
> - For system coprocessors, just use the configuration of the container.
> - Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value>{,}).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4048) [Coprocessors] Support
configuration of coprocessor at load time
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058551#comment-13058551 ]
jiraposter@reviews.apache.org commented on HBASE-4048:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/984/#review951
-----------------------------------------------------------
src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java
<https://reviews.apache.org/r/984/#comment2024>
Instead of an interface inside an interface, how about lifting the four Priority constants to Coprocessor ?
- Ted
On 2011-07-01 08:00:54, Andrew Purtell wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/984/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-07-01 08:00:54)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Users should be able to pass configuration options to coprocessors. These options should be applied at load time.
bq.
bq. - For system coprocessors, just use the configuration of the container.
bq.
bq. - Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value>{,}).
bq.
bq. Also fixes the outstanding issue where coprocessor priority is supposed to be an integer range but is constrained by the Coprocessor.Priority enum to 4 values.
bq.
bq.
bq. This addresses bug HBASE-4048.
bq. https://issues.apache.org/jira/browse/HBASE-4048
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java c2ea442
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java ac5387a
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 5bae05a
bq. src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java 4800bea
bq. src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java a98117f
bq. src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java 796742c
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java 58a09f8
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java 969b1f3
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java 0cdf7d1
bq.
bq. Diff: https://reviews.apache.org/r/984/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Modified o.a.h.h.coprocessor.TestClassLoading to check new functionality.
bq.
bq.
bq. Thanks,
bq.
bq. Andrew
bq.
bq.
> [Coprocessors] Support configuration of coprocessor at load time
> ----------------------------------------------------------------
>
> Key: HBASE-4048
> URL: https://issues.apache.org/jira/browse/HBASE-4048
> Project: HBase
> Issue Type: Improvement
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Fix For: 0.92.0
>
> Attachments: HBASE-4048.patch
>
>
> Users should be able to pass configuration options to coprocessors. These options should be applied at load time.
> - For system coprocessors, just use the configuration of the container.
> - Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value>{,}).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4048) [Coprocessors] Support configuration
of coprocessor at load time
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Purtell updated HBASE-4048:
----------------------------------
Attachment: HBASE-4048.patch
Final patch after review.
> [Coprocessors] Support configuration of coprocessor at load time
> ----------------------------------------------------------------
>
> Key: HBASE-4048
> URL: https://issues.apache.org/jira/browse/HBASE-4048
> Project: HBase
> Issue Type: Improvement
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Fix For: 0.92.0
>
> Attachments: HBASE-4048.patch, HBASE-4048.patch
>
>
> Users should be able to pass configuration options to coprocessors. These options should be applied at load time.
> - For system coprocessors, just use the configuration of the container.
> - Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value>{,}).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4048) [Coprocessors] Support
configuration of coprocessor at load time
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058082#comment-13058082 ]
jiraposter@reviews.apache.org commented on HBASE-4048:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/984/
-----------------------------------------------------------
(Updated 2011-06-30 21:16:28.392221)
Review request for hbase.
Summary (updated)
-------
Users should be able to pass configuration options to coprocessors. These options should be applied at load time.
- For system coprocessors, just use the configuration of the container.
- Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value>{,}).
Also fixes the outstanding issue where coprocessor priority is supposed to be an integer range but is constrained by the Coprocessor.Priority enum to 4 values.
This addresses bug HBASE-4048.
https://issues.apache.org/jira/browse/HBASE-4048
Diffs
-----
src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java c2ea442
src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java ac5387a
src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 5bae05a
src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java 4800bea
src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java a98117f
src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java 796742c
src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java 58a09f8
src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java 969b1f3
src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java 0cdf7d1
Diff: https://reviews.apache.org/r/984/diff
Testing
-------
Modified o.a.h.h.coprocessor.TestClassLoading to check new functionality.
Thanks,
Andrew
> [Coprocessors] Support configuration of coprocessor at load time
> ----------------------------------------------------------------
>
> Key: HBASE-4048
> URL: https://issues.apache.org/jira/browse/HBASE-4048
> Project: HBase
> Issue Type: Improvement
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Fix For: 0.92.0
>
>
> Users should be able to pass configuration options to coprocessors. These options should be applied at load time.
> - For system coprocessors, just use the configuration of the container.
> - Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value>{,}).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4048) [Coprocessors] Support
configuration of coprocessor at load time
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058248#comment-13058248 ]
jiraposter@reviews.apache.org commented on HBASE-4048:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/984/
-----------------------------------------------------------
(Updated 2011-07-01 08:00:54.357860)
Review request for hbase.
Changes
-------
Fix oversight in not making interface Priority constants final, pointed out by Ted.
Summary
-------
Users should be able to pass configuration options to coprocessors. These options should be applied at load time.
- For system coprocessors, just use the configuration of the container.
- Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value>{,}).
Also fixes the outstanding issue where coprocessor priority is supposed to be an integer range but is constrained by the Coprocessor.Priority enum to 4 values.
This addresses bug HBASE-4048.
https://issues.apache.org/jira/browse/HBASE-4048
Diffs (updated)
-----
src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java c2ea442
src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java ac5387a
src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 5bae05a
src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java 4800bea
src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java a98117f
src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java 796742c
src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java 58a09f8
src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java 969b1f3
src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java 0cdf7d1
Diff: https://reviews.apache.org/r/984/diff
Testing
-------
Modified o.a.h.h.coprocessor.TestClassLoading to check new functionality.
Thanks,
Andrew
> [Coprocessors] Support configuration of coprocessor at load time
> ----------------------------------------------------------------
>
> Key: HBASE-4048
> URL: https://issues.apache.org/jira/browse/HBASE-4048
> Project: HBase
> Issue Type: Improvement
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Fix For: 0.92.0
>
> Attachments: HBASE-4048.patch
>
>
> Users should be able to pass configuration options to coprocessors. These options should be applied at load time.
> - For system coprocessors, just use the configuration of the container.
> - Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value>{,}).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4048) [Coprocessors] Support
configuration of coprocessor at load time
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058161#comment-13058161 ]
jiraposter@reviews.apache.org commented on HBASE-4048:
------------------------------------------------------
bq. On 2011-06-30 21:56:16, Ted Yu wrote:
bq. > src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java, line 31
bq. > <https://reviews.apache.org/r/984/diff/1/?file=21839#file21839line31>
bq. >
bq. > Would an abstract class be more appropriate here ?
Because this is an Interface, the compiler will substitute static final values while processing code that references it without generating class files. Isn't that preferable here, given Priority is used equivalently to a C/C++ #define?
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/984/#review936
-----------------------------------------------------------
On 2011-06-30 21:16:28, Andrew Purtell wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/984/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-06-30 21:16:28)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Users should be able to pass configuration options to coprocessors. These options should be applied at load time.
bq.
bq. - For system coprocessors, just use the configuration of the container.
bq.
bq. - Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value>{,}).
bq.
bq. Also fixes the outstanding issue where coprocessor priority is supposed to be an integer range but is constrained by the Coprocessor.Priority enum to 4 values.
bq.
bq.
bq. This addresses bug HBASE-4048.
bq. https://issues.apache.org/jira/browse/HBASE-4048
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java c2ea442
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java ac5387a
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 5bae05a
bq. src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java 4800bea
bq. src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java a98117f
bq. src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java 796742c
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java 58a09f8
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java 969b1f3
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java 0cdf7d1
bq.
bq. Diff: https://reviews.apache.org/r/984/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Modified o.a.h.h.coprocessor.TestClassLoading to check new functionality.
bq.
bq.
bq. Thanks,
bq.
bq. Andrew
bq.
bq.
> [Coprocessors] Support configuration of coprocessor at load time
> ----------------------------------------------------------------
>
> Key: HBASE-4048
> URL: https://issues.apache.org/jira/browse/HBASE-4048
> Project: HBase
> Issue Type: Improvement
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Fix For: 0.92.0
>
> Attachments: HBASE-4048.patch
>
>
> Users should be able to pass configuration options to coprocessors. These options should be applied at load time.
> - For system coprocessors, just use the configuration of the container.
> - Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value>{,}).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4048) [Coprocessors] Support configuration
of coprocessor at load time
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Purtell updated HBASE-4048:
----------------------------------
Attachment: HBASE-4048.patch
> [Coprocessors] Support configuration of coprocessor at load time
> ----------------------------------------------------------------
>
> Key: HBASE-4048
> URL: https://issues.apache.org/jira/browse/HBASE-4048
> Project: HBase
> Issue Type: Improvement
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Fix For: 0.92.0
>
> Attachments: HBASE-4048.patch
>
>
> Users should be able to pass configuration options to coprocessors. These options should be applied at load time.
> - For system coprocessors, just use the configuration of the container.
> - Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value>{,}).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4048) [Coprocessors] Support
configuration of coprocessor at load time
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058737#comment-13058737 ]
Hudson commented on HBASE-4048:
-------------------------------
Integrated in HBase-TRUNK #2000 (See [https://builds.apache.org/job/HBase-TRUNK/2000/])
HBASE-4048 Support configuration of coprocessor at load time
apurtell :
Files :
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverInterface.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java
> [Coprocessors] Support configuration of coprocessor at load time
> ----------------------------------------------------------------
>
> Key: HBASE-4048
> URL: https://issues.apache.org/jira/browse/HBASE-4048
> Project: HBase
> Issue Type: Improvement
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Fix For: 0.92.0
>
> Attachments: HBASE-4048.patch, HBASE-4048.patch
>
>
> Users should be able to pass configuration options to coprocessors. These options should be applied at load time.
> - For system coprocessors, just use the configuration of the container.
> - Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value>{,}).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira