You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/10 07:20:58 UTC
[GitHub] [incubator-superset] graceguo-supercat opened a new pull request #11994: feat: add invisible layer on loading chart
graceguo-supercat opened a new pull request #11994:
URL: https://github.com/apache/incubator-superset/pull/11994
### SUMMARY
When chart is loading, we show a spinner icon on top of chart, but it won't block user interact with chart. This will cause some issue for filter box: In large dashboard user applies a filter, other filter may update accordingly. If user interact with filter box while it is waiting for query results, it will cause dashboard in a wired state or show errors.
This PR is to add an invisible layer on top of chart when it is in loading state (while loading spinner is showing).
### TEST PLAN
CI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on pull request #11994: feat: add invisible layer on loading chart
Posted by GitBox <gi...@apache.org>.
etr2460 commented on pull request #11994:
URL: https://github.com/apache/incubator-superset/pull/11994#issuecomment-742693786
Could you attach screenshots/a test plan around this too? Making the chart `position: relative` seems like it might cause some bugs. wanna make sure everything's tested with scrolling, tabs, etc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat merged pull request #11994: feat: add invisible layer on loading chart
Posted by GitBox <gi...@apache.org>.
graceguo-supercat merged pull request #11994:
URL: https://github.com/apache/incubator-superset/pull/11994
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat commented on pull request #11994: feat: add invisible layer on loading chart
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on pull request #11994:
URL: https://github.com/apache/incubator-superset/pull/11994#issuecomment-742709707
this will be invisible layer look like if i add some color for it (color will not committed in this PR):
<img width="1188" alt="Screen Shot 2020-12-10 at 10 28 26 AM" src="https://user-images.githubusercontent.com/27990562/101814170-a292b980-3ad2-11eb-9691-2773a76cadab.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat commented on pull request #11994: feat: add invisible layer on loading chart
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on pull request #11994:
URL: https://github.com/apache/incubator-superset/pull/11994#issuecomment-742700111
The screenshot in the description is the UI after this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat edited a comment on pull request #11994: feat: add invisible layer on loading chart
Posted by GitBox <gi...@apache.org>.
graceguo-supercat edited a comment on pull request #11994:
URL: https://github.com/apache/incubator-superset/pull/11994#issuecomment-742709707
this will be _invisible layer_ look like if i add some color for it (color will not committed in this PR):
<img width="1188" alt="Screen Shot 2020-12-10 at 10 28 26 AM" src="https://user-images.githubusercontent.com/27990562/101814170-a292b980-3ad2-11eb-9691-2773a76cadab.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org