You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2020/10/29 16:59:37 UTC
[GitHub] [cassandra] smiklosovic opened a new pull request #796: CASSANDRA-14477 - 3.11 The check of num_tokens against the length of inital_token in the yaml triggers unexpectedly
smiklosovic opened a new pull request #796:
URL: https://github.com/apache/cassandra/pull/796
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] michaelsembwever commented on a change in pull request #796: CASSANDRA-14477 - 3.11 The check of num_tokens against the length of inital_token in the yaml triggers unexpectedly
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on a change in pull request #796:
URL: https://github.com/apache/cassandra/pull/796#discussion_r521259043
##########
File path: src/java/org/apache/cassandra/config/DatabaseDescriptor.java
##########
@@ -314,7 +314,8 @@ private static InetAddress getNetworkInterfaceAddress(String intf, String config
}
}
- private static void setConfig(Config config)
+ @VisibleForTesting
+ public static void setConfig(Config config)
Review comment:
Would it be safer (better practice) for the tests to work with their own `Config` instance, avoiding using static state of `DatabaseDescriptor`?
With method signature `applyTokensConfig(Config config)` you can avoid making public the `DatabaseDescriptor.setConfig(..)` method. This is the approach that was done in the 3.0 patch, see https://github.com/apache/cassandra/pull/795/files#diff-054af65b8d690b0fddc3e0a4ef05a80d8f1d6689b4f77912795fec019200666cR293
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic closed pull request #796: CASSANDRA-14477 - 3.11 The check of num_tokens against the length of inital_token in the yaml triggers unexpectedly
Posted by GitBox <gi...@apache.org>.
smiklosovic closed pull request #796:
URL: https://github.com/apache/cassandra/pull/796
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org