You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "GutoVeronezi (via GitHub)" <gi...@apache.org> on 2023/06/10 04:31:38 UTC
[GitHub] [cloudstack] GutoVeronezi opened a new pull request, #7617: Retrieve only resource count on user dashboard
GutoVeronezi opened a new pull request, #7617:
URL: https://github.com/apache/cloudstack/pull/7617
### Description
The user's dashboard presents the user's amount of running VMs, stopped VMs, total VMs, volumes, networks, and public IP addresses. The APIs `listVirtualMachines`, `listVolumes`, `listNetworks`, and `listPublicIpAddresses` process and return the whole data, which can be slow when dealing with a great number of resources. However, for the user's dashboard context, we just need the count of resources.
This PR intends to create a new parameter (`retrieveonlyresourcecount`) in those APIs to skip the data processing and return only the resource count.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
### Screenshots (if appropriate):
### How Has This Been Tested?
I created several VMs in my environment, logged in with a domain admin, and observed how much time the dashboard was taking to completely load. Before the changes, it was taking more than 30 seconds to load and the time would increase according to the amount of resources:
With the changes it is taking around 2 seconds to completely load:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7617: Retrieve only resource count on user dashboard
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7617:
URL: https://github.com/apache/cloudstack/pull/7617#issuecomment-1585479814
@GutoVeronezi a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7617: Retrieve only resource count on user dashboard
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7617:
URL: https://github.com/apache/cloudstack/pull/7617#issuecomment-1593723349
<b>[SF] Trillian test result (tid-6742)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43355 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7617-t6742-kvm-centos7.zip
Smoke tests completed. 111 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #7617: Retrieve only resource count on user dashboard
Posted by "GutoVeronezi (via GitHub)" <gi...@apache.org>.
GutoVeronezi commented on PR #7617:
URL: https://github.com/apache/cloudstack/pull/7617#issuecomment-1615229208
@rohityadavcloud, `listAccounts` returns only the resources belonging to the account, which produces a different result than the expected: resources that the account has access to.
Anyways, the PR is not limited to the dashboard case, as I pointed in https://github.com/apache/cloudstack/pull/7617#issuecomment-1586403372, and still is a valid use case that adds to ACS. Also, the PR complied with the community requirements (approval and test passing); therefore, the opinion of a specific person is not mandatory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #7617: Retrieve only resource count on user dashboard
Posted by "GutoVeronezi (via GitHub)" <gi...@apache.org>.
GutoVeronezi commented on PR #7617:
URL: https://github.com/apache/cloudstack/pull/7617#issuecomment-1585838544
> @GutoVeronezi Is it better to create a separate API to list all resource counts ?
@weizhouapache, as the APIs we have today already return the data we need; we would just need to improve the processes [with the new parameter]. Therefore, I believe there is no need for a new API [to maintain] that would do the same function as the others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7617: Retrieve only resource count on user dashboard
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7617:
URL: https://github.com/apache/cloudstack/pull/7617#issuecomment-1585586623
@GutoVeronezi
Is it better to create a separate API to list all resource counts ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #7617: Retrieve only resource count on user dashboard
Posted by "GutoVeronezi (via GitHub)" <gi...@apache.org>.
GutoVeronezi commented on PR #7617:
URL: https://github.com/apache/cloudstack/pull/7617#issuecomment-1614709664
Errors in https://github.com/apache/cloudstack/actions/runs/5249960611/jobs/9861114168?pr=7617 does not seem related to this PR; merging this one based on the package results, test results and approval.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #7617: Retrieve only resource count on user dashboard
Posted by "GutoVeronezi (via GitHub)" <gi...@apache.org>.
GutoVeronezi commented on PR #7617:
URL: https://github.com/apache/cloudstack/pull/7617#issuecomment-1586403372
@weizhouapache, creating an API to return a handful of resource counts will limit the users to the data we (the developers) define the API to return; for new use cases, we would have to extend the API to return a new resource count, which makes it a limited approach.
On the other hand, creating the proposed parameter in those APIs will give users the flexibility to combine the API parameters the way they want. The user's dashboard is just an example of where we can use the parameter; however, we have to remember that users can and will consume the APIs in different ways. Therefore, with that in addition to my initial point, I believe that the parameter creation in this scenario is a better approach rather than creating an API, as it brings flexibility for the users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7617: Retrieve only resource count on user dashboard
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7617:
URL: https://github.com/apache/cloudstack/pull/7617#issuecomment-1585784896
<b>[SF] Trillian test result (tid-6718)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38986 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7617-t6718-kvm-centos7.zip
Smoke tests completed. 111 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7617: Retrieve only resource count on user dashboard
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7617:
URL: https://github.com/apache/cloudstack/pull/7617#issuecomment-1592614658
@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland closed pull request #7617: Retrieve only resource count on user dashboard
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland closed pull request #7617: Retrieve only resource count on user dashboard
URL: https://github.com/apache/cloudstack/pull/7617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #7617: Retrieve only resource count on user dashboard
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #7617:
URL: https://github.com/apache/cloudstack/pull/7617#issuecomment-1585557093
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7617: Retrieve only resource count on user dashboard
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #7617:
URL: https://github.com/apache/cloudstack/pull/7617#issuecomment-1614928758
Sorry I'm late to the discussion, this PR wasn't really needed. The information we need is largely in the listAccounts API, which is then used to display the account usage/quota/limits. For ex, see: https://qa.cloudstack.cloud/simulator/#/account/36b4c0a4-b339-40f0-9991-b17282a686a9?tab=resources
A single API call would also save from calling too many API calls for the user/project dashboard. I think we can optimise things in future with this approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #7617: Retrieve only resource count on user dashboard
Posted by "GutoVeronezi (via GitHub)" <gi...@apache.org>.
GutoVeronezi commented on PR #7617:
URL: https://github.com/apache/cloudstack/pull/7617#issuecomment-1613963448
ping @weizhouapache
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7617: Retrieve only resource count on user dashboard
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7617:
URL: https://github.com/apache/cloudstack/pull/7617#issuecomment-1600122571
@weizhouapache are your concerns addressed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7617: Retrieve only resource count on user dashboard
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7617:
URL: https://github.com/apache/cloudstack/pull/7617#issuecomment-1614629912
> @weizhouapache are your concerns addressed?
yes.
No objections @DaanHoogland @GutoVeronezi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi merged pull request #7617: Retrieve only resource count on user dashboard
Posted by "GutoVeronezi (via GitHub)" <gi...@apache.org>.
GutoVeronezi merged PR #7617:
URL: https://github.com/apache/cloudstack/pull/7617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7617: Retrieve only resource count on user dashboard
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7617:
URL: https://github.com/apache/cloudstack/pull/7617#issuecomment-1585497030
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/7617?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#7617](https://app.codecov.io/gh/apache/cloudstack/pull/7617?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f89613f) into [main](https://app.codecov.io/gh/apache/cloudstack/commit/ae10263b3b373b22c1522280cc93a48dc761c483?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ae10263) will **increase** coverage by `0.00%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## main #7617 +/- ##
=========================================
Coverage 13.03% 13.03%
Complexity 9077 9077
=========================================
Files 2728 2728
Lines 256997 257003 +6
Branches 40067 40069 +2
=========================================
+ Hits 33509 33510 +1
- Misses 219284 219286 +2
- Partials 4204 4207 +3
```
| [Impacted Files](https://app.codecov.io/gh/apache/cloudstack/pull/7617?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ain/java/com/cloud/api/query/QueryManagerImpl.java](https://app.codecov.io/gh/apache/cloudstack/pull/7617?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2FwaS9xdWVyeS9RdWVyeU1hbmFnZXJJbXBsLmphdmE=) | `2.93% <0.00%> (-0.01%)` | :arrow_down: |
... and [1 file with indirect coverage changes](https://app.codecov.io/gh/apache/cloudstack/pull/7617/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7617: Retrieve only resource count on user dashboard
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7617:
URL: https://github.com/apache/cloudstack/pull/7617#issuecomment-1585495177
Packaging result [LL]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #7617: Retrieve only resource count on user dashboard
Posted by "GutoVeronezi (via GitHub)" <gi...@apache.org>.
GutoVeronezi commented on PR #7617:
URL: https://github.com/apache/cloudstack/pull/7617#issuecomment-1585479735
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7617: Retrieve only resource count on user dashboard
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7617:
URL: https://github.com/apache/cloudstack/pull/7617#issuecomment-1588982807
@weizhouapache a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7617: Retrieve only resource count on user dashboard
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7617:
URL: https://github.com/apache/cloudstack/pull/7617#issuecomment-1588981811
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7617: Retrieve only resource count on user dashboard
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7617:
URL: https://github.com/apache/cloudstack/pull/7617#issuecomment-1586120336
> > @GutoVeronezi Is it better to create a separate API to list all resource counts ?
>
> @weizhouapache, as the APIs we have today already return the data we need; we would just need to improve the processes [with the new parameter]. Therefore, I believe there is no need for a new API [to maintain] that would do the same function as the others.
@GutoVeronezi
I think it is better to get all resource counts/limitations by a single API call, not multiple api calls as you can see on the UI source code. You can refer to
https://cloudstack.apache.org/api/apidocs-4.18/apis/listInfrastructure.html
https://cloudstack.apache.org/api/apidocs-4.18/apis/listZonesMetrics.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland closed pull request #7617: Retrieve only resource count on user dashboard
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland closed pull request #7617: Retrieve only resource count on user dashboard
URL: https://github.com/apache/cloudstack/pull/7617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7617: Retrieve only resource count on user dashboard
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7617:
URL: https://github.com/apache/cloudstack/pull/7617#issuecomment-1592613920
@blueorangutan test keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7617: Retrieve only resource count on user dashboard
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7617:
URL: https://github.com/apache/cloudstack/pull/7617#issuecomment-1586719080
@GutoVeronezi
I think an API is better.
back to your pr, I think it would be better to create an abstract class .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7617: Retrieve only resource count on user dashboard
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7617:
URL: https://github.com/apache/cloudstack/pull/7617#issuecomment-1589084094
Packaging result [LL]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6138
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7617: Retrieve only resource count on user dashboard
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7617:
URL: https://github.com/apache/cloudstack/pull/7617#issuecomment-1585557548
@shwstppr a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org