[jira] [Comment Edited] (MRELEASE-899) release:prepare should not change the line separator but detect effective line separator from pom.xml

["Alexander Kriegisch (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MRELEASE-899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468362#comment-17468362 ] 

Alexander Kriegisch edited comment on MRELEASE-899 at 1/4/22, 5:22 AM:
-----------------------------------------------------------------------

[~michael-o], the issue is 7 years old. The last time I reproduced it was 13 months ago. Since then, I might have changed my settings, such as global Git options, Maven version, Git for Windows version. Currently, I cannot reproduce the problem in the GitHub reproducer project I had created long ago. That does not necessarily mean that it is solved, it might just work for my current combination of settings. I am also working in another project now and have new hardware. This is the problem with code rot - you never know if the issue is solved or just not being reproduced due to some changes in system environment. So now we know nothing, really. I hope that someone else can enlighten us more here.


was (Author: kriegaex):
[~michael-o], the issue is 7 years old. The last time I reproduced it was 13 months ago. Since then, I might have changed my settings, such as global Git options, Maven version, Git for Windows version. Currently, I cannot reproduce the problem in the GitHub reproducer project I had created long ago. That does not necessarily mean that it is solved, it might just work for my current combination of settings. This is the problem with code rot - you never know if the issue is solved or just not being reproduced due to some changes in system environment. So now we know nothing, really. I hope that someone else can enlighten us more here.

> release:prepare should not change the line separator but detect effective line separator from pom.xml
> -----------------------------------------------------------------------------------------------------
>
>                 Key: MRELEASE-899
>                 URL: https://issues.apache.org/jira/browse/MRELEASE-899
>             Project: Maven Release Plugin
>          Issue Type: Improvement
>            Reporter: Ralph van Etten
>            Priority: Major
>
> Currently the plugin use the system property {{line.separator}} when it rewrites the pom.xml.
> This causes trouble, because every line in changed, when a project is released sometimes under Windows and sometimes under Linux (because of its different line separators). (http://stackoverflow.com/questions/11868590/maven-release-plugin-and-windows-line-breaks)
> Therefore it would be a nice feature when the plugin would not use the systems line separator but the line separator that is already used in the pom.xml.
> On the other hand, changing the existing behaviour would maybe, also harm someone else.
> Therefore it would be an great feature when there would be an property that define the expected behaviour, maybe in the same way it is done by the maven-assembly-plugin's property fileSet.lineEnding (http://maven.apache.org/plugins/maven-assembly-plugin/component.html#class_fileSet)



--
This message was sent by Atlassian Jira
(v8.20.1#820001)