You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by mgaido91 <gi...@git.apache.org> on 2018/06/25 10:08:17 UTC

[GitHub] spark pull request #21403: [SPARK-24341][SQL] Support only IN subqueries wit...

Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21403#discussion_r197743862
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala ---
    @@ -2261,6 +2261,24 @@ class DataFrameSuite extends QueryTest with SharedSQLContext {
         assert(df.queryExecution.executedPlan.isInstanceOf[WholeStageCodegenExec])
       }
     
    +  test("SPARK-24341: IN subqueries with struct fields") {
    --- End diff --
    
    I cannot really add them there since I need to intercept `AnalysisException` here, but if you have suggestions about better places for this, I am happy to move it.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org