You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Greg Rahn (Code Review)" <ge...@cloudera.org> on 2018/10/25 21:49:00 UTC
[Impala-ASF-CR] IMPALA-7759: Add Levenshtein edit distance built-in function
Greg Rahn has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11793
Change subject: IMPALA-7759: Add Levenshtein edit distance built-in function
......................................................................
IMPALA-7759: Add Levenshtein edit distance built-in function
This patch adds new built-in functions to calculate Levenshtein edit
distance. Implemented as levenshtein() to match PostgreSQL in
both functionality and name and also added le_dst() alias for Netezza,
compatibility, but note that levenshtein() differs in functionality in
that if either value is NULL or both values are NULL, levenshtein()
returns NULL, where Netezza's le_dst() returns the length of the not
NULL value or 0 if both values are NULL.
Testing:
- Added unit tests to expr-test.cc
- Manual test on 966289 string pairs and results match PostgreSQL
Change-Id: I549d33ab7cebfa10db2934461c8ec91e2cc1cdcb
---
M be/src/exprs/expr-test.cc
M be/src/exprs/string-functions-ir.cc
M be/src/exprs/string-functions.h
M common/function-registry/impala_functions.py
4 files changed, 68 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/11793/1
--
To view, visit http://gerrit.cloudera.org:8080/11793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I549d33ab7cebfa10db2934461c8ec91e2cc1cdcb
Gerrit-Change-Number: 11793
Gerrit-PatchSet: 1
Gerrit-Owner: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-7759: Add Levenshtein edit distance built-in function
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11793 )
Change subject: IMPALA-7759: Add Levenshtein edit distance built-in function
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3512/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/11793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I549d33ab7cebfa10db2934461c8ec91e2cc1cdcb
Gerrit-Change-Number: 11793
Gerrit-PatchSet: 4
Gerrit-Owner: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sun, 02 Dec 2018 06:46:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7759: Add Levenshtein edit distance built-in function
Posted by "Greg Rahn (Code Review)" <ge...@cloudera.org>.
Greg Rahn has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/11793 )
Change subject: IMPALA-7759: Add Levenshtein edit distance built-in function
......................................................................
IMPALA-7759: Add Levenshtein edit distance built-in function
This patch adds new built-in functions to calculate Levenshtein edit
distance. Implemented as levenshtein() to match PostgreSQL in
both functionality and name and also added le_dst() alias for Netezza,
compatibility, but note that levenshtein() differs in functionality in
that if either value is NULL or both values are NULL, levenshtein()
returns NULL, where Netezza's le_dst() returns the length of the not
NULL value or 0 if both values are NULL.
Testing:
- Added unit tests to expr-test.cc
- Manual test on 966289 string pairs and results match PostgreSQL
- Added changes to qgen tests for PostgreSQL comparison
Change-Id: I549d33ab7cebfa10db2934461c8ec91e2cc1cdcb
---
M be/src/exprs/expr-test.cc
M be/src/exprs/string-functions-ir.cc
M be/src/exprs/string-functions.h
M common/function-registry/impala_functions.py
A tests/comparison/compat.py
M tests/comparison/discrepancy_searcher.py
M tests/comparison/funcs.py
7 files changed, 141 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/11793/4
--
To view, visit http://gerrit.cloudera.org:8080/11793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I549d33ab7cebfa10db2934461c8ec91e2cc1cdcb
Gerrit-Change-Number: 11793
Gerrit-PatchSet: 4
Gerrit-Owner: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-7759: Add Levenshtein edit distance built-in function
Posted by "Greg Rahn (Code Review)" <ge...@cloudera.org>.
Greg Rahn has posted comments on this change. ( http://gerrit.cloudera.org:8080/11793 )
Change subject: IMPALA-7759: Add Levenshtein edit distance built-in function
......................................................................
Patch Set 4:
> Added length checking and error tests
> Fixed typo in compat.py
--
To view, visit http://gerrit.cloudera.org:8080/11793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I549d33ab7cebfa10db2934461c8ec91e2cc1cdcb
Gerrit-Change-Number: 11793
Gerrit-PatchSet: 4
Gerrit-Owner: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sun, 02 Dec 2018 05:36:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7759: Add Levenshtein edit distance built-in function
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11793 )
Change subject: IMPALA-7759: Add Levenshtein edit distance built-in function
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I549d33ab7cebfa10db2934461c8ec91e2cc1cdcb
Gerrit-Change-Number: 11793
Gerrit-PatchSet: 4
Gerrit-Owner: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sun, 02 Dec 2018 10:39:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7759: Add Levenshtein edit distance built-in function
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11793 )
Change subject: IMPALA-7759: Add Levenshtein edit distance built-in function
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1507/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I549d33ab7cebfa10db2934461c8ec91e2cc1cdcb
Gerrit-Change-Number: 11793
Gerrit-PatchSet: 4
Gerrit-Owner: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sun, 02 Dec 2018 06:09:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7759: Add Levenshtein edit distance built-in function
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11793 )
Change subject: IMPALA-7759: Add Levenshtein edit distance built-in function
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11793/3/be/src/exprs/string-functions-ir.cc
File be/src/exprs/string-functions-ir.cc:
http://gerrit.cloudera.org:8080/#/c/11793/3/be/src/exprs/string-functions-ir.cc@1127
PS3, Line 1127: // https://en.wikibooks.org/wiki/Algorithm_Implementation/Strings/Levenshtein_distance#C++
line too long (92 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/11793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I549d33ab7cebfa10db2934461c8ec91e2cc1cdcb
Gerrit-Change-Number: 11793
Gerrit-PatchSet: 3
Gerrit-Owner: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Nov 2018 06:21:31 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7759: Add Levenshtein edit distance built-in function
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11793 )
Change subject: IMPALA-7759: Add Levenshtein edit distance built-in function
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Soft +2 for the qgen changes.
http://gerrit.cloudera.org:8080/#/c/11793/3/tests/comparison/compat.py
File tests/comparison/compat.py:
http://gerrit.cloudera.org:8080/#/c/11793/3/tests/comparison/compat.py@21
PS3, Line 21: s
Oops, I had a typo here. Should be "exist".
--
To view, visit http://gerrit.cloudera.org:8080/11793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I549d33ab7cebfa10db2934461c8ec91e2cc1cdcb
Gerrit-Change-Number: 11793
Gerrit-PatchSet: 3
Gerrit-Owner: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Nov 2018 16:26:48 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7759: Add Levenshtein edit distance built-in function
Posted by "Greg Rahn (Code Review)" <ge...@cloudera.org>.
Greg Rahn has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/11793 )
Change subject: IMPALA-7759: Add Levenshtein edit distance built-in function
......................................................................
IMPALA-7759: Add Levenshtein edit distance built-in function
This patch adds new built-in functions to calculate Levenshtein edit
distance. Implemented as levenshtein() to match PostgreSQL in
both functionality and name and also added le_dst() alias for Netezza,
compatibility, but note that levenshtein() differs in functionality in
that if either value is NULL or both values are NULL, levenshtein()
returns NULL, where Netezza's le_dst() returns the length of the not
NULL value or 0 if both values are NULL.
Testing:
- Added unit tests to expr-test.cc
- Manual test on 966289 string pairs and results match PostgreSQL
- Added changes to qgen tests for PostgreSQL comparison
Change-Id: I549d33ab7cebfa10db2934461c8ec91e2cc1cdcb
---
M be/src/exprs/expr-test.cc
M be/src/exprs/string-functions-ir.cc
M be/src/exprs/string-functions.h
M common/function-registry/impala_functions.py
A tests/comparison/compat.py
M tests/comparison/discrepancy_searcher.py
M tests/comparison/funcs.py
7 files changed, 128 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/11793/3
--
To view, visit http://gerrit.cloudera.org:8080/11793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I549d33ab7cebfa10db2934461c8ec91e2cc1cdcb
Gerrit-Change-Number: 11793
Gerrit-PatchSet: 3
Gerrit-Owner: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-7759: Add Levenshtein edit distance built-in function
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11793 )
Change subject: IMPALA-7759: Add Levenshtein edit distance built-in function
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1167/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I549d33ab7cebfa10db2934461c8ec91e2cc1cdcb
Gerrit-Change-Number: 11793
Gerrit-PatchSet: 1
Gerrit-Owner: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Oct 2018 22:23:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7759: Add Levenshtein edit distance built-in function
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11793 )
Change subject: IMPALA-7759: Add Levenshtein edit distance built-in function
......................................................................
IMPALA-7759: Add Levenshtein edit distance built-in function
This patch adds new built-in functions to calculate Levenshtein edit
distance. Implemented as levenshtein() to match PostgreSQL in
both functionality and name and also added le_dst() alias for Netezza,
compatibility, but note that levenshtein() differs in functionality in
that if either value is NULL or both values are NULL, levenshtein()
returns NULL, where Netezza's le_dst() returns the length of the not
NULL value or 0 if both values are NULL.
Testing:
- Added unit tests to expr-test.cc
- Manual test on 966289 string pairs and results match PostgreSQL
- Added changes to qgen tests for PostgreSQL comparison
Change-Id: I549d33ab7cebfa10db2934461c8ec91e2cc1cdcb
Reviewed-on: http://gerrit.cloudera.org:8080/11793
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exprs/expr-test.cc
M be/src/exprs/string-functions-ir.cc
M be/src/exprs/string-functions.h
M common/function-registry/impala_functions.py
A tests/comparison/compat.py
M tests/comparison/discrepancy_searcher.py
M tests/comparison/funcs.py
7 files changed, 141 insertions(+), 4 deletions(-)
Approvals:
Tim Armstrong: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/11793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I549d33ab7cebfa10db2934461c8ec91e2cc1cdcb
Gerrit-Change-Number: 11793
Gerrit-PatchSet: 5
Gerrit-Owner: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-7759: Add Levenshtein edit distance built-in function
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11793 )
Change subject: IMPALA-7759: Add Levenshtein edit distance built-in function
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I549d33ab7cebfa10db2934461c8ec91e2cc1cdcb
Gerrit-Change-Number: 11793
Gerrit-PatchSet: 4
Gerrit-Owner: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sun, 02 Dec 2018 06:46:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7759: Add Levenshtein edit distance built-in function
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11793 )
Change subject: IMPALA-7759: Add Levenshtein edit distance built-in function
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1450/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I549d33ab7cebfa10db2934461c8ec91e2cc1cdcb
Gerrit-Change-Number: 11793
Gerrit-PatchSet: 3
Gerrit-Owner: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Nov 2018 06:56:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7759: Add Levenshtein edit distance built-in function
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11793 )
Change subject: IMPALA-7759: Add Levenshtein edit distance built-in function
......................................................................
Patch Set 1:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/11793/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11793/1//COMMIT_MSG@10
PS1, Line 10: distance. Implemented as levenshtein() to match PostgreSQL in
If it's identical to the postgres function we could add it to the random query generator in tests/comparison/funcs.py - see for example Length
http://gerrit.cloudera.org:8080/#/c/11793/1/be/src/exprs/string-functions-ir.cc
File be/src/exprs/string-functions-ir.cc:
http://gerrit.cloudera.org:8080/#/c/11793/1/be/src/exprs/string-functions-ir.cc@1113
PS1, Line 1113: // https://en.wikibooks.org/wiki/Algorithm_Implementation/Strings/Levenshtein_distance#C++
Long line. We also need to figure out what the license is so that it's clear this is legit.
http://gerrit.cloudera.org:8080/#/c/11793/1/be/src/exprs/string-functions-ir.cc@1127
PS1, Line 1127: auto column_start = (decltype(s1len))1;
I'd just go with the less clever:
int column_start = 1;
http://gerrit.cloudera.org:8080/#/c/11793/1/be/src/exprs/string-functions-ir.cc@1129
PS1, Line 1129: auto column = new decltype(s1len)[s1len + 1];
It would be better to use context->Allocate<int>() and Free() instead of new so that we can track the memory, etc.
http://gerrit.cloudera.org:8080/#/c/11793/1/be/src/exprs/string-functions-ir.cc@1132
PS1, Line 1132: auto
I'd just use int instead of auto in most of these places - it's less clever but more obvious
--
To view, visit http://gerrit.cloudera.org:8080/11793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I549d33ab7cebfa10db2934461c8ec91e2cc1cdcb
Gerrit-Change-Number: 11793
Gerrit-PatchSet: 1
Gerrit-Owner: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Oct 2018 23:28:01 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7759: Add Levenshtein edit distance built-in function
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11793 )
Change subject: IMPALA-7759: Add Levenshtein edit distance built-in function
......................................................................
Patch Set 3:
The changes look good to me, just need the length validation
--
To view, visit http://gerrit.cloudera.org:8080/11793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I549d33ab7cebfa10db2934461c8ec91e2cc1cdcb
Gerrit-Change-Number: 11793
Gerrit-PatchSet: 3
Gerrit-Owner: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 Nov 2018 01:13:29 +0000
Gerrit-HasComments: No