[GitHub] [incubator-zipkin] adriancole opened a new pull request #2576: Simplifies build by bundling Scribe (still disabled by default)

[GitBox <gi...@apache.org>]

adriancole opened a new pull request #2576: Simplifies build by bundling Scribe (still disabled by default)
URL: https://github.com/apache/incubator-zipkin/pull/2576
 
 
   We used to bundle scribe, but due to library conflicts, moved it
   optional. As Armeria natively supports thrift (incidentally armeria
   means sea thrift), we no longer have this problem.
   
   Bundling removes one of the most complex things from our project for
   sites that still use Scribe (most folks who use Finagle will).
   
   This adds 1MiB to the server jar, which could be reduced further if
   needed by:
   * inlining scribe types instead of using the large generated files
   * somehow removing the libthrift dep
   
   I don't think this is worthwhile yet.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services