You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/05 13:56:39 UTC
[GitHub] [airflow] wojsamjan opened a new pull request #17445: Add info log how to fix: More than one pod running with labels
wojsamjan opened a new pull request #17445:
URL: https://github.com/apache/airflow/pull/17445
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
Logs information how to fix issue with: "More than one pod running with labels" - using is_delete_operator_pod argument when creating new KubernetesPodOperator
This is just a simple update which adds an extra info log how to avoid the mentioned problem. It does not change a logic at all.
Flag ensures that every time a pod is being deleted. So we always end up with single and unique running pod.
related: #10544
Accidentally closed: #17285
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #17445: Add info log how to fix: More than one pod running with labels
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on pull request #17445:
URL: https://github.com/apache/airflow/pull/17445#issuecomment-920099991
@wojsamjan, yeah, if folks continue to hit this it won't be due to `is_delete_operator_pod` or `reattach_on_restart`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #17445: Add info log how to fix: More than one pod running with labels
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on pull request #17445:
URL: https://github.com/apache/airflow/pull/17445#issuecomment-893700450
As I mentioned in the other PR, I think the right fix is to only attempt to reattach to running pods. If we were to offer advice in a log message, setting `reattach_on_restart` to false might be better advice?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] wojsamjan commented on pull request #17445: Add info log how to fix: More than one pod running with labels
Posted by GitBox <gi...@apache.org>.
wojsamjan commented on pull request #17445:
URL: https://github.com/apache/airflow/pull/17445#issuecomment-919815655
@jedcunningham as I understand I should close this PR, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] wojsamjan commented on pull request #17445: Add info log how to fix: More than one pod running with labels
Posted by GitBox <gi...@apache.org>.
wojsamjan commented on pull request #17445:
URL: https://github.com/apache/airflow/pull/17445#issuecomment-898506490
Hi, sorry for my late response. I have just gone through the code, how it should work with this flag set to False. And it should work, maybe this could be better. On Monday morning I will make a test of it and I will be back with response. I am also wondering, maybe 2 logs would be actually helpful. If someone wants to keep their pods and create all the time a new one - then your advice might be helpful. If someone else would like to re-attach (maybe its faster?) and deleting (to do not mess with running multiple pods) then my advice could be helpful as well. And in case that someone would like to create & delete the pod each time - then both could have sense.
@jedcunningham What do you think about it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham closed pull request #17445: Add info log how to fix: More than one pod running with labels
Posted by GitBox <gi...@apache.org>.
jedcunningham closed pull request #17445:
URL: https://github.com/apache/airflow/pull/17445
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #17445: Add info log how to fix: More than one pod running with labels
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on pull request #17445:
URL: https://github.com/apache/airflow/pull/17445#issuecomment-914616883
#18070 will fix the underlying issue allowing `is_delete_operator_pod=False` and
`reattach_on_restart=True` to function together properly during retries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org