You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gaston Kleiman <ga...@mesosphere.io> on 2017/10/02 21:00:05 UTC

Review Request 62735: Disable on Windows new tests that use file URIs.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62735/
-----------------------------------------------------------

Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.


Repository: mesos


Description
-------

URIs pointing to local paths are not supported on Windows yet.

This patch disables on Windows the new tests that make sure that file
URIs are fetched for tasks started by the default executor.


Diffs
-----

  src/tests/default_executor_tests.cpp 63952d97b76c3e16973705cb0b16140dd381b7ce 


Diff: https://reviews.apache.org/r/62735/diff/1/


Testing
-------


Thanks,

Gaston Kleiman


Re: Review Request 62735: Disable on Windows new tests that use file URIs.

Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62735/#review186890
-----------------------------------------------------------


Ship it!




Ship It!

- Andrew Schwartzmeyer


On Oct. 2, 2017, 2 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62735/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2017, 2 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> URIs pointing to local paths are not supported on Windows yet.
> 
> This patch disables on Windows the new tests that make sure that file
> URIs are fetched for tasks started by the default executor.
> 
> 
> Diffs
> -----
> 
>   src/tests/default_executor_tests.cpp 63952d97b76c3e16973705cb0b16140dd381b7ce 
> 
> 
> Diff: https://reviews.apache.org/r/62735/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>