You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/03/25 11:30:07 UTC
[GitHub] [incubator-seatunnel] ruanwenjun opened a new issue #1568: [Feature][module] Splite the connectors module with source and sink
ruanwenjun opened a new issue #1568:
URL: https://github.com/apache/incubator-seatunnel/issues/1568
### Search before asking
- [X] I had searched in the [feature](https://github.com/apache/incubator-seatunnel/issues?q=is%3Aissue+label%3A%22Feature%22) and found no similar feature requirement.
### Description
Right now, we put the source and sink plugin in a same connector module.
There may hard to find out how many source and sink plugin are already supported from the code. Since may exist some connectors only implements source or sink.
I suggest splitting the connectors module into source module and sink module. This may make the increase the module number, but I think this is needed.
### Usage Scenario
_No response_
### Related issues
_No response_
### Are you willing to submit a PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] wuchunfu commented on issue #1568: [Feature][connectors] Split the connectors module with source and sink
Posted by GitBox <gi...@apache.org>.
wuchunfu commented on issue #1568:
URL: https://github.com/apache/incubator-seatunnel/issues/1568#issuecomment-1079176765
I don't think it's necessary to do this if it's just to better see what source and sink plugins are available. What I worry about is whether it will affect the build time and increase the package size if you split too many modules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun edited a comment on issue #1568: [Feature][connectors] Split the connectors module with source and sink
Posted by GitBox <gi...@apache.org>.
ruanwenjun edited a comment on issue #1568:
URL: https://github.com/apache/incubator-seatunnel/issues/1568#issuecomment-1079107781
> Maybe we can use some maven plugin to figure out which ones source/sink do we support？
This is a way, but can we just get the plugin types from the module name rather than execute the maven command? Do you have any concern about splitting the source and sink into different module?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun closed issue #1568: [Feature][connectors] Split the connectors module with source and sink
Posted by GitBox <gi...@apache.org>.
ruanwenjun closed issue #1568:
URL: https://github.com/apache/incubator-seatunnel/issues/1568
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun commented on issue #1568: [Feature][connectors] Split the connectors module with source and sink
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on issue #1568:
URL: https://github.com/apache/incubator-seatunnel/issues/1568#issuecomment-1079539273
Thanks for join this discussion and give the opinion, right now this change is not necessary indeed.
I close this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun commented on issue #1568: [Feature][module] Splite the connectors module with source and sink
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on issue #1568:
URL: https://github.com/apache/incubator-seatunnel/issues/1568#issuecomment-1078931959
@BenJFan @wuchunfu @CalvinKirs @dongzl What do you think, welcome to discuss.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] BenJFan commented on issue #1568: [Feature][connectors] Split the connectors module with source and sink
Posted by GitBox <gi...@apache.org>.
BenJFan commented on issue #1568:
URL: https://github.com/apache/incubator-seatunnel/issues/1568#issuecomment-1078991964
Maybe we can use some maven plugin to figure out which ones source/sink do we support？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun commented on issue #1568: [Feature][connectors] Split the connectors module with source and sink
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on issue #1568:
URL: https://github.com/apache/incubator-seatunnel/issues/1568#issuecomment-1079538604
> I don't think it's necessary to do this if it's just to better see what source and sink plugins are available. What I worry about is whether it will affect the build time and increase the package size if you split too many modules.
Yes, it may increase the build time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org