You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2022/12/02 16:53:30 UTC
[GitHub] [daffodil] stevedlawrence opened a new pull request, #885: Add infosetWalkerSkipMin/Max tunables
stevedlawrence opened a new pull request, #885:
URL: https://github.com/apache/daffodil/pull/885
Allows configuration of how often the InfosetWalker skips walk() calls. Setting to a value of zero disables skipping walk() calls. A value of zero is useful during testing to ensure the InfosetWalker isn't incorrectly removing infoset elements, which can lead to seemingly random null pointer exceptions.
Add multiple tests to show that the InfosetWalker currently removes infoset elements that are still needed by separator logic, that this does not arise in a particular case with the default skip min/max values, and that disabling infoset removal works around the issue.
DAFFODIL-2755
Note, this does not fix 2755, just makes it easier to create a reproducible test to trigger the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] stevedlawrence merged pull request #885: Add infosetWalkerSkipMin/Max tunables
Posted by GitBox <gi...@apache.org>.
stevedlawrence merged PR #885:
URL: https://github.com/apache/daffodil/pull/885
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] mbeckerle commented on a diff in pull request #885: Add infosetWalkerSkipMin/Max tunables
Posted by GitBox <gi...@apache.org>.
mbeckerle commented on code in PR #885:
URL: https://github.com/apache/daffodil/pull/885#discussion_r1038368059
##########
daffodil-propgen/src/main/resources/org/apache/daffodil/xsd/dafext.xsd:
##########
@@ -207,6 +207,38 @@
</xs:restriction>
</xs:simpleType>
</xs:element>
+ <xs:element name="infosetWalkerSkipMin" default="32" minOccurs="0">
+ <xs:annotation>
+ <xs:documentation>
+ Daffodil periodically walks the internal infoset to send events to the configured
+ InfosetOutputter, skipping at least this number of walk attempts. Larger values
+ mean delayed InfosetOutputter events and more memory usage; Smaller values mean
+ more CPU usage. Set this value to zero to never skip any walk attempts.
Review Comment:
Suggest adding phrasing that this is specifically for an advanced testing behavior, and should not need to be adjusted by users ever.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org