You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "Anoop Sam John (JIRA)" <ji...@apache.org> on 2017/09/20 10:31:00 UTC

[jira] [Comment Edited] (HBASE-18825) Use HStoreFile instead of StoreFile in our own code base and remove unnecessary methods in StoreFile interface

    [ https://issues.apache.org/jira/browse/HBASE-18825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16172992#comment-16172992 ] 

Anoop Sam John edited comment on HBASE-18825 at 9/20/17 10:30 AM:
------------------------------------------------------------------

bq.And for the config of region implementation class, I agree that we can remove it for now if no one use it.
+1. And another issue.
Yes RSS case I will continue.. Pls review the latest patch there.
On StoreFile -> HStoreFile in our code base, I don't have any strong reason to object.  As Stack mentioned that is against the notion of interface based coding.   But we can argue that our coding is based on the direct impl class only basically.. The interface we made just to pass the objects (With limited capability/expose) to CPs.  :-)


was (Author: anoop.hbase):
bq.And for the config of region implementation class, I agree that we can remove it for now if no one use it.
+1. And another issue.
Yes RSS case I will continue.. Pls review the latest patch there.
On StoreFile -> HStoreFile in our code base, I dont have any string reason to object.  As Stack mentioned that is against the notion of interface based coding.   But we can argue that our coding is based on the direct impl class only basically.. The interface we made just to pass the objects (With limited capability/expose) to CPs.  :-)

> Use HStoreFile instead of StoreFile in our own code base and remove unnecessary methods in StoreFile interface
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-18825
>                 URL: https://issues.apache.org/jira/browse/HBASE-18825
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Coprocessors
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>             Fix For: 2.0.0-alpha-4
>
>         Attachments: HBASE-18825.patch, HBASE-18825-v1.patch, HBASE-18825-v2.patch, HBASE-18825-v3.patch, HBASE-18825-v3.patch
>
>
> Use generic types to avoid too many casts.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)