[jira] [Commented] (BEAM-1660) withCoder() error in JdbcIO JavaDoc example

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15902182#comment-15902182 ] 

ASF GitHub Bot commented on BEAM-1660:
--------------------------------------

GitHub user XuMingmin opened a pull request:

    https://github.com/apache/beam/pull/2203

    BEAM-1660 withCoder() error in JdbcIO JavaDoc example

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/XuMingmin/beam BEAM-1660

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2203.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2203
    
----
commit 82ad89e56cc4099d52ff9440255ec2b05f83a9c0
Author: mingmxu <mi...@ebay.com>
Date:   2017-03-08T23:42:46Z

    update JavaDoc to ensure the examples runnable;

----


> withCoder() error in JdbcIO JavaDoc example
> -------------------------------------------
>
>                 Key: BEAM-1660
>                 URL: https://issues.apache.org/jira/browse/BEAM-1660
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-extensions
>    Affects Versions: 0.6.0
>            Reporter: Xu Mingmin
>            Assignee: Xu Mingmin
>            Priority: Minor
>
> Follow the JavaDoc of JdbcIO, job fails with exception:
> {code}
> Exception in thread "main" java.lang.IllegalStateException: JdbcIO.read() requires a coder to be set via withCoder(coder)
> 	at com.google.common.base.Preconditions.checkState(Preconditions.java:176)
> 	at org.apache.beam.sdk.io.jdbc.JdbcIO$Read.validate(JdbcIO.java:329)
> 	at org.apache.beam.sdk.io.jdbc.JdbcIO$Read.validate(JdbcIO.java:249)
> 	at org.apache.beam.sdk.Pipeline.applyInternal(Pipeline.java:419)
> 	at org.apache.beam.sdk.Pipeline.applyTransform(Pipeline.java:350)
> 	at org.apache.beam.sdk.values.PBegin.apply(PBegin.java:58)
> 	at org.apache.beam.sdk.Pipeline.apply(Pipeline.java:172)
> {code}
> It requires a Coder provided by withCoder. Need to add it in the example.
> Other point is, does it really need to specify a Coder? Users should register it with CoderRegistry I think.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)