[jira] [Commented] (YARN-953) [YARN-321] Enable ResourceManager to write history data

["Vinod Kumar Vavilapalli (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13820472#comment-13820472 ] 

Vinod Kumar Vavilapalli commented on YARN-953:
----------------------------------------------

Comments on the patch:
 - history-writer.dispatcher-vector-size -> history-writer.multithreadeddispatcher.pool-size.
 - history-writer.store.class -> history-writer.class
 - I thought DummyApplicationHistoryStore is going away. But it's fine I guess. Atleast DummyApplicationHistoryStore -> NullApplicationHistoryStore.
 - No need to mention version numbers in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/pom.xml?
 - Change the dispatcher name to be something like MultiThreadedDispatcher ?
 - Like your usage of hashCode for multiplexing events!
 - WritingHistoryEventType: Drop WRITING_ prefix from all events.
 - Instead of putting in more code, let's fix the app-finishes-before-appattempt bug when killing an app separately. We discussed this in the context of RM restart too.
 - Instead of creating new events from container, we can write container-history events in app when RMAppAttemptContainerAllocatedEvent and RMAppAttemptContainerFinishedEvent. Otherwise, we risk creating far more events.
 - TestRMApplicationHistoryWriter: increment -> incrementCounts

> [YARN-321] Enable ResourceManager to write history data
> -------------------------------------------------------
>
>                 Key: YARN-953
>                 URL: https://issues.apache.org/jira/browse/YARN-953
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Vinod Kumar Vavilapalli
>            Assignee: Zhijie Shen
>         Attachments: YARN-953-5.patch, YARN-953.1.patch, YARN-953.2.patch, YARN-953.3.patch, YARN-953.4.patch, YARN-953.5.patch, YARN-953.6.patch, YARN-953.7.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.1#6144)