You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apex.apache.org by chandnisingh <gi...@git.apache.org> on 2016/04/29 20:31:57 UTC
[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2068 made noop defa...
GitHub user chandnisingh opened a pull request:
https://github.com/apache/incubator-apex-malhar/pull/259
APEXMALHAR-2068 made noop default in FileSplitter
@tweise @vrozov made noop default in FileSplitterInput
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chandnisingh/incubator-apex-malhar APEXMALHAR-2068
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-apex-malhar/pull/259.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #259
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2068 made noop defa...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-apex-malhar/pull/259
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2068 made noop defa...
Posted by chandnisingh <gi...@git.apache.org>.
Github user chandnisingh commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/259#discussion_r61659396
--- Diff: library/src/main/java/com/datatorrent/lib/io/fs/FileSplitterInput.java ---
@@ -96,7 +96,7 @@ public FileSplitterInput()
{
super();
currentWindowRecoveryState = Lists.newLinkedList();
- idempotentStorageManager = new IdempotentStorageManager.FSIdempotentStorageManager();
+ idempotentStorageManager = new IdempotentStorageManager.NoopIdempotentStorageManager();
--- End diff --
The reason to make this change is that if multiple ```FSIdempotentStorageManager```s are used in an application then their state (on disk) collide. The jira APEXMALHAR-2068 is opened to address that.
The problem in having FSIdempotentStorageManager as default is that the users get bewildered because of in-correct behavior manifested by the bug mentioned above.
If the user sets FSIdempotentStorageManage explicitly then they can ensure to make the relative path unique as well.
Not setting any default entails additional step of setting an Idempotent storage manager even when the user doesn't care about idempotency.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2068 made noop defa...
Posted by PramodSSImmaneni <gi...@git.apache.org>.
Github user PramodSSImmaneni commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/259#discussion_r61627655
--- Diff: library/src/main/java/com/datatorrent/lib/io/fs/FileSplitterInput.java ---
@@ -96,7 +96,7 @@ public FileSplitterInput()
{
super();
currentWindowRecoveryState = Lists.newLinkedList();
- idempotentStorageManager = new IdempotentStorageManager.FSIdempotentStorageManager();
+ idempotentStorageManager = new IdempotentStorageManager.NoopIdempotentStorageManager();
--- End diff --
I understand why we don't want to use FSIdempotentStorageManger in FileSplitter as FileSplitter is more generic than FS. However I think setting Noop disables idempotency by default. How about letting the user knowingly make that choice by not creating it in the operator and set to @NotNull so the user will have to set it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---