You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by ag...@apache.org on 2015/03/03 02:43:25 UTC
android commit: Delete no longer relevant comments about
``
Repository: cordova-android
Updated Branches:
refs/heads/master afdac9b41 -> 53dba8678
Delete no longer relevant comments about `<url-filter>`
Project: http://git-wip-us.apache.org/repos/asf/cordova-android/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-android/commit/53dba867
Tree: http://git-wip-us.apache.org/repos/asf/cordova-android/tree/53dba867
Diff: http://git-wip-us.apache.org/repos/asf/cordova-android/diff/53dba867
Branch: refs/heads/master
Commit: 53dba8678c90f06ee3bdaf903ec1ffa1106be338
Parents: afdac9b
Author: Andrew Grieve <ag...@chromium.org>
Authored: Mon Mar 2 20:43:10 2015 -0500
Committer: Andrew Grieve <ag...@chromium.org>
Committed: Mon Mar 2 20:43:10 2015 -0500
----------------------------------------------------------------------
framework/src/org/apache/cordova/CordovaPlugin.java | 2 +-
framework/src/org/apache/cordova/PluginManager.java | 4 ----
2 files changed, 1 insertion(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-android/blob/53dba867/framework/src/org/apache/cordova/CordovaPlugin.java
----------------------------------------------------------------------
diff --git a/framework/src/org/apache/cordova/CordovaPlugin.java b/framework/src/org/apache/cordova/CordovaPlugin.java
index c223f5c..e4b3ace 100644
--- a/framework/src/org/apache/cordova/CordovaPlugin.java
+++ b/framework/src/org/apache/cordova/CordovaPlugin.java
@@ -229,7 +229,7 @@ public class CordovaPlugin {
}
/**
- * By specifying a <url-filter> in config.xml you can map a URL (using startsWith atm) to this method.
+ * Allows plugins to handle a link being clicked. Return true here to cancel the navigation.
*
* @param url The URL that is trying to be loaded in the Cordova webview.
* @return Return true to prevent the URL from loading. Default is false.
http://git-wip-us.apache.org/repos/asf/cordova-android/blob/53dba867/framework/src/org/apache/cordova/PluginManager.java
----------------------------------------------------------------------
diff --git a/framework/src/org/apache/cordova/PluginManager.java b/framework/src/org/apache/cordova/PluginManager.java
index f850342..4787542 100755
--- a/framework/src/org/apache/cordova/PluginManager.java
+++ b/framework/src/org/apache/cordova/PluginManager.java
@@ -424,10 +424,6 @@ public class PluginManager {
* @return Return false to allow the URL to load, return true to prevent the URL from loading.
*/
public boolean onOverrideUrlLoading(String url) {
- // Deprecated way to intercept URLs. (process <url-filter> tags).
- // Instead, plugins should not include <url-filter> and instead ensure
- // that they are loaded before this function is called (either by setting
- // the onload <param> or by making an exec() call to them)
for (PluginEntry entry : this.entryMap.values()) {
CordovaPlugin plugin = pluginMap.get(entry.service);
if (plugin != null && plugin.onOverrideUrlLoading(url)) {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org