[GitHub] [lucene] madrob commented on pull request #11971: Disable useless error-prone checks (libraries/frameworks we do not use)

[GitBox <gi...@apache.org>]

madrob commented on PR #11971:
URL: https://github.com/apache/lucene/pull/11971#issuecomment-1325628423

   > > Github won't let me comment on the line but we don't use theory library
   > 
   > Do you refer to this check? https://errorprone.info/bugpattern/TheoryButNoTheories
   > 
   > I didn't touch it simply because these classes (Theory/DataPoint/DataPoints) are in junit API. But yeah, if we don't do those kinds of tests, let's nuke this check.
   
   Ah, ok, they used to be in a separate library but I guess JUnit adopted them. We don't have any of those annotations. And I think they require a specialized runner anyway, which might not be compatible with RandomizedRunner.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org