You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2021/12/24 17:22:07 UTC
[GitHub] [logging-log4j2] carterkozak opened a new pull request #655: LOG4J2-3288 Interpolator non-plugin ctor includes all core lookups
carterkozak opened a new pull request #655:
URL: https://github.com/apache/logging-log4j2/pull/655
This adds missing lookups: `bundle`, `event`, and `sd`
There's a comment suggesting that the PluginManager could be used,
however that will require additional validation before I'm comfortable
enabling it: Logging initialization is very static and tricky,
and it's easy to produce deadlocks when referencing logging code
within initialization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] garydgregory commented on pull request #655: LOG4J2-3288 Interpolator non-plugin ctor includes all core lookups
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #655:
URL: https://github.com/apache/logging-log4j2/pull/655#issuecomment-1000905659
Woa, aren't we missing unit tests that exercise those lookups?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] carterkozak merged pull request #655: LOG4J2-3288 Interpolator non-plugin ctor includes all core lookups
Posted by GitBox <gi...@apache.org>.
carterkozak merged pull request #655:
URL: https://github.com/apache/logging-log4j2/pull/655
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] garydgregory commented on pull request #655: LOG4J2-3288 Interpolator non-plugin ctor includes all core lookups
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #655:
URL: https://github.com/apache/logging-log4j2/pull/655#issuecomment-1000907893
Double woa ;-) thank you for the clarification :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] carterkozak commented on pull request #655: LOG4J2-3288 Interpolator non-plugin ctor includes all core lookups
Posted by GitBox <gi...@apache.org>.
carterkozak commented on pull request #655:
URL: https://github.com/apache/logging-log4j2/pull/655#issuecomment-1000906261
> Woa, aren't we missing unit tests that exercise those lookups?
I think the issue is abundance of branches.
The non-plugin constructor is used initially when the configuration is created, to interpolate the Property values themselves, then the interpolator is replaced with one which does use plugins. Existing uses of `config.getStrSubstitutor()` would work fine, while `new StrSubstitutor()` and some overloads would not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] carterkozak edited a comment on pull request #655: LOG4J2-3288 Interpolator non-plugin ctor includes all core lookups
Posted by GitBox <gi...@apache.org>.
carterkozak edited a comment on pull request #655:
URL: https://github.com/apache/logging-log4j2/pull/655#issuecomment-1000906261
> Woa, aren't we missing unit tests that exercise those lookups?
I think the issue is abundance of branches.
The non-plugin constructor is used initially when the configuration is created to interpolate the Property values themselves, then the interpolator is replaced with one which does use plugins. Existing uses of `config.getStrSubstitutor()` would work fine, while `new StrSubstitutor()` and some overloads would not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org