You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by on...@apache.org on 2016/07/13 16:37:52 UTC
svn commit: r1752451 -
/poi/site/src/documentation/content/xdocs/guidelines.xml
Author: onealj
Date: Wed Jul 13 16:37:52 2016
New Revision: 1752451
URL: http://svn.apache.org/viewvc?rev=1752451&view=rev
Log:
update checklist before submitting a patch section of submitting a patch guidelines
Modified:
poi/site/src/documentation/content/xdocs/guidelines.xml
Modified: poi/site/src/documentation/content/xdocs/guidelines.xml
URL: http://svn.apache.org/viewvc/poi/site/src/documentation/content/xdocs/guidelines.xml?rev=1752451&r1=1752450&r2=1752451&view=diff
==============================================================================
--- poi/site/src/documentation/content/xdocs/guidelines.xml (original)
+++ poi/site/src/documentation/content/xdocs/guidelines.xml Wed Jul 13 16:37:52 2016
@@ -229,21 +229,21 @@
</section>
<section><title>checklist before submitting a patch</title>
<ul>
- <li>added code complies with <link href="#CodeStyle">coding standards</link></li>
- <li>added code compiles and runs on java 1.6</li>
- <li>new java files begin with the <link href="http://www.apache.org/foundation/license-faq.html">
- apache software license</link> statement.</li>
- <li>the code does not depend on gpl or lgpl code.</li>
- <li>the code doesn't include @author tags</li>
- <li>existing test cases succeed.</li>
- <li>new test cases written and succeed.</li>
- <li>documentation page extended as appropriate.</li>
- <li>examples updated / added as appropriate.</li>
- <li>diff files generated using svn diff</li>
- <li>newly added files are included in the patch / alongside the patch</li>
- <li>the bugzilla subject dev contains [patch], task name and patch reason in subject.</li>
- <li>the bugzilla description contains a rationale for the patch.</li>
- <li>attachment to the bugzilla entry contains the patch file(s).</li>
+ <li>Added code complies with <link href="#CodeStyle">coding standards</link>.</li>
+ <li>Added code compiles and runs on Java 1.6.</li>
+ <li>New java files begin with the <link href="https://www.apache.org/foundation/license-faq.html">
+ Apache Software License</link> statement.</li>
+ <li>The code does not depend on code that is unlicensed or incompatibly licensed with ASL 2.0. <link href="https://www.apache.org/licenses/GPL-compatibility.html">GPL</link> and LGPL code may not be used.</li>
+ <li>The code does not include <code>@author</code> tags.</li>
+ <li>Existing test cases succeed.</li>
+ <li>New test cases written and succeed (Use <code>@Ignore</code> from <code>org.junit</code> for in-progress work).</li>
+ <li>Documentation page extended as appropriate.</li>
+ <li>Examples updated or added as appropriate.</li>
+ <li>Diff files generated using <code>svn diff</code>.</li>
+ <li>Newly added files are included in the patch or alongside the patch.</li>
+ <li>The <link href="https://bz.apache.org/bugzilla/describecomponents.cgi?product=POI">bugzilla</link> subject dev contains [PATCH], task name and patch reason in subject.</li>
+ <li>The bugzilla description contains a rationale for the patch.</li>
+ <li>Attachment to the bugzilla entry contains the patch file.</li>
</ul>
</section>
</section>
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org