[GitHub] [spark] grundprinzip commented on a diff in pull request #39254: [SPARK-41333][SPARK-41737] Implement `GroupedData.{min, max, avg, sum}`

[GitBox <gi...@apache.org>]

grundprinzip commented on code in PR #39254:
URL: https://github.com/apache/spark/pull/39254#discussion_r1058066012


##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -1061,6 +1068,81 @@ class SparkConnectPlanner(session: SparkSession) {
     }
   }
 
+  private def transformNumericAggregate(agg: proto.Aggregate): LogicalPlan = {

Review Comment:
   Is that duplication really necessary? What exactly is the difference on the server side for the numeric aggregation? Do we have this special handling in Catalyst for this special case?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org