[jira] [Comment Edited] (OFBIZ-7339) Replace EntityUtilProperties getPropertyValue method with correct method calls

["Rishi Solanki (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15331354#comment-15331354 ] 

Rishi Solanki edited comment on OFBIZ-7339 at 6/15/16 8:13 AM:
---------------------------------------------------------------

Yes [~jacques.le.roux] we have seen your discussion on it with Wai on dev list. Here we are trying to address the practice we should follow while using the OFBiz API. Generally one method solves all purpose and users start using that method everywhere with custom conversions. I see Wai's patch on OFBIZ-7112 check for db values and override the property values. Here we have only made changes in method call, so I think we are good as changed methods call signature doesn't changed in that work. Also checked that no dependency of both improvements as we are just changing the calls.

Thank you for your help!


was (Author: rishisolankii):
Yes [~jacques.le.roux] we have seen your discussion on it with Wai on dev list. Here we are trying to address the practice we should follow while using the OFBiz API. Generally one method solves all purpose and users start using that method everywhere with custom conversions. I see Wai's patch on OFBIZ-7112 check for db values and override the property values. Here we have only made changes in method call, so I think we are good as changed methods call signature doesn't changed in that work.

Thank you for your help!

> Replace EntityUtilProperties getPropertyValue method with correct method calls
> ------------------------------------------------------------------------------
>
>                 Key: OFBIZ-7339
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7339
>             Project: OFBiz
>          Issue Type: Bug
>          Components: content, framework, manufacturing, party, product, securityext, specialpurpose/ecommerce, specialpurpose/lucene, specialpurpose/passport, workeffort
>    Affects Versions: Trunk
>            Reporter: Rishi Solanki
>         Attachments: EntityUtilProperties.patch
>
>
> In current OFBiz system at many places many methods implemented but not used as per their purpose. One example is in EntityUtilProperties we have getPropertyAsInteger() and getPropertyAsBigDecimal() and other methods which returns specific type data. But at most places system uses getPropertyValue() which returns string and then do explicit conversions.
> System should use proper methods for which they have been implemented.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)