You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by kalyan kumar kalvagadda via Review Board <no...@reviews.apache.org> on 2017/11/01 19:25:07 UTC
Re: Review Request 63424: SENTRY-2024: Specify Char Set for
AUTHZ_OBJ_NAME
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63424/#review189827
-----------------------------------------------------------
Your description here is not in-line with the comments in jira. Jira states that intent of your change is to be in-line with the hive char set. Doing so it would solve another issue you may see. Please confirm.
- kalyan kumar kalvagadda
On Oct. 30, 2017, 6:34 p.m., Na Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63424/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2017, 6:34 p.m.)
>
>
> Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Sergio Pena.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> AUTHZ_OBJ_NAME has (384) chars. If its table char set is utf8, the constrain AUTHZOBJNAME will have error "Specified key was too long; max key length is 767 bytes"
> The solution is to specify the char set for this field, so it works for mysql regardless the char set of its table or DB.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.mysql.sql a7db1b7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-2.0.0.sql 9f61154
>
>
> Diff: https://reviews.apache.org/r/63424/diff/1/
>
>
> Testing
> -------
>
> tested on system
>
>
> Thanks,
>
> Na Li
>
>
Re: Review Request 63424: SENTRY-2024: Specify Char Set for
AUTHZ_OBJ_NAME
Posted by Na Li via Review Board <no...@reviews.apache.org>.
> On Nov. 1, 2017, 7:25 p.m., kalyan kumar kalvagadda wrote:
> > Your description here is not in-line with the comments in jira. Jira states that intent of your change is to be in-line with the hive char set. Doing so it would solve another issue you may see. Please confirm.
I have updated this description to be in-line with the comments in jira.
- Na
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63424/#review189827
-----------------------------------------------------------
On Nov. 1, 2017, 7:32 p.m., Na Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63424/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2017, 7:32 p.m.)
>
>
> Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Sergio Pena.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> AUTHZ_OBJ_NAME has (384) chars. It is defieved from DB_NAME and TBL_NAME from hive. hive is using latin1 char set for those fields. To be consistent with hive, specify this field in sentry to latin1.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.mysql.sql a7db1b7
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-2.0.0.sql 9f61154
>
>
> Diff: https://reviews.apache.org/r/63424/diff/1/
>
>
> Testing
> -------
>
> tested on system
>
>
> Thanks,
>
> Na Li
>
>