You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/25 14:20:46 UTC

[GitHub] [airflow] XD-DENG commented on pull request #13884: Fix wrong parameter for drawDagStatsForDag() in dags.html

XD-DENG commented on pull request #13884:
URL: https://github.com/apache/airflow/pull/13884#issuecomment-766848218


   > This is certainly a typo. With and without the fix, I see no issues in the browser. Would take a bit more effort to determine if/why it is necessary to be there at all.
   
   Hi @ryanahamilton , yes you are right, there will be no issue without this fix. Because of the typo, this parameter is not useful/helpful at all. When `.data(states)` is called, it cannot find `states` in its current block, so it goes one level up, and `states` is available there https://github.com/apache/airflow/blob/326c74e60871736f43c303068b0aaa5927c50de0/airflow/www/templates/airflow/dags.html#L460-L463
   
   This may become a potential source of error/confusion though in the future, so fixing it. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org