You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Nixon Rodrigues <ni...@freestoneinfotech.com> on 2016/09/02 12:49:44 UTC

Review Request 51598: ATLAS-1133 : Jetty Server start doesn't throw exception when user-credential.properties file is not found

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51598/
-----------------------------------------------------------

Review request for atlas, Madhan Neethiraj, Shwetha GS, and Vimal Sharma.


Repository: atlas


Description
-------

This patch contains original fix ie to throw RuntimeException when usercredentails file and polciystore file are not in filepath.
Secondly this patch has the fix for path in UnitTest case and jsp compilation issue by adding jetty-jsp as dependency in jetty-maven-plugin in pom.xml.


Diffs
-----

  authorization/src/main/java/org/apache/atlas/authorize/simple/SimpleAtlasAuthorizer.java 30e2067 
  webapp/pom.xml 708a216 
  webapp/src/main/java/org/apache/atlas/web/dao/UserDao.java 6b83c21 
  webapp/src/test/java/org/apache/atlas/web/security/NegativeSSLAndKerberosTest.java 4ad01cf 

Diff: https://reviews.apache.org/r/51598/diff/


Testing
-------

Executed *quick_start.py* script and tested the Atlas UI from distro module.
Ran *mvn --projects webapp jetty:run* and tested atlas UI, created tags, searched tags.
Executed Unit testcase *mvn clean install*


Thanks,

Nixon Rodrigues


Re: Review Request 51598: ATLAS-1133 : Jetty Server start doesn't throw exception when user-credential.properties file is not found

Posted by Vimal Sharma <vi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51598/#review148479
-----------------------------------------------------------


Ship it!




Ship It!

- Vimal Sharma


On Sept. 2, 2016, 12:49 p.m., Nixon Rodrigues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51598/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2016, 12:49 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Shwetha GS, and Vimal Sharma.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> This patch contains original fix ie to throw RuntimeException when usercredentails file and polciystore file are not in filepath.
> Secondly this patch has the fix for path in UnitTest case and jsp compilation issue by adding jetty-jsp as dependency in jetty-maven-plugin in pom.xml.
> 
> 
> Diffs
> -----
> 
>   authorization/src/main/java/org/apache/atlas/authorize/simple/SimpleAtlasAuthorizer.java 30e2067 
>   webapp/pom.xml 708a216 
>   webapp/src/main/java/org/apache/atlas/web/dao/UserDao.java 6b83c21 
>   webapp/src/test/java/org/apache/atlas/web/security/NegativeSSLAndKerberosTest.java 4ad01cf 
> 
> Diff: https://reviews.apache.org/r/51598/diff/
> 
> 
> Testing
> -------
> 
> Executed *quick_start.py* script and tested the Atlas UI from distro module.
> Ran *mvn --projects webapp jetty:run* and tested atlas UI, created tags, searched tags.
> Executed Unit testcase *mvn clean install*
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>