You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/09/18 12:00:09 UTC

[GitHub] [apisix] spacewander commented on a diff in pull request #7926: fix: check config.yaml plugins list is nil

spacewander commented on code in PR #7926:
URL: https://github.com/apache/apisix/pull/7926#discussion_r973709454


##########
apisix/admin/init.lua:
##########
@@ -258,17 +258,21 @@ local function sync_local_conf_to_etcd(reset)
     local local_conf = core.config.local_conf()
 
     local plugins = {}
-    for _, name in ipairs(local_conf.plugins) do
-        core.table.insert(plugins, {
-            name = name,
-        })
+    if local_conf.plugins then

Review Comment:
   In what situation people will use an empty plugin list?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org