You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/04/14 16:31:25 UTC
[jira] [Commented] (KAFKA-3558) Add compression_type parameter to
benchmarks in benchmark_test.py
[ https://issues.apache.org/jira/browse/KAFKA-3558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15241259#comment-15241259 ]
ASF GitHub Bot commented on KAFKA-3558:
---------------------------------------
GitHub user ijuma opened a pull request:
https://github.com/apache/kafka/pull/1221
KAFKA-3558; Add compression_type parameter to benchmarks in benchmark_test.py
* Accept an optional `compress_type` argument in `EndToEndLatency.scala`
* Use a fixed `Random` seed in `EndToEndLatency.scala` for determinism
* Add `compression_type` to and remove `consumer_fetch_max_wait` from `end_to_end_latency.py`. The latter was never used.
* Add `compression_type` to `benchmark_test.py` methods and add `snappy` to `matrix` annotation
* Use randomly generated bytes from a restricted range for `ProducerPerformance` payload. This is a simple fix for now. It can be improved in the PR for KAFKA-3554.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijuma/kafka kafka-3558-add-compression_type-benchmark_test.py
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/1221.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1221
----
commit e74e3757e42e3c23dd1d37b84f3a19a36a3f4e73
Author: Ismael Juma <is...@juma.me.uk>
Date: 2016-04-14T12:52:33Z
Minor clean-ups in `ConsumerPerformance`
commit d6323b16ddbaa0994012cd6e5270f5413cbabf87
Author: Ismael Juma <is...@juma.me.uk>
Date: 2016-04-14T12:53:49Z
Accept an optional compress_type argument in `EndToEndLatency.scala`
commit a01c12c85a7201fbe3e6fa352f81a04517a34076
Author: Ismael Juma <is...@juma.me.uk>
Date: 2016-04-14T12:54:23Z
Use a fixed `Random` seed in `EndToEndLatency.scala`
commit dfcec34fb2e5a6d522ff8ac26233d06c8f26ee1f
Author: Ismael Juma <is...@juma.me.uk>
Date: 2016-04-14T13:06:48Z
Add `compression_type` to and remove `consumer_fetch_max_wait` from `end_to_end_latency.py`
commit d9862262c2dc1b4b600f78241ebc38f01060f40f
Author: Ismael Juma <is...@juma.me.uk>
Date: 2016-04-14T13:08:51Z
Add `compression_type` to `benchmark_test.py`
commit 076e9d8720c5534d7bf4cc4fea7cceb72a178626
Author: Ismael Juma <is...@juma.me.uk>
Date: 2016-04-14T13:31:52Z
Use randomly generated bytes from a restricted range for `ProducerPerformance` payload
Used the same range as `EndToEndLatency`
----
> Add compression_type parameter to benchmarks in benchmark_test.py
> -----------------------------------------------------------------
>
> Key: KAFKA-3558
> URL: https://issues.apache.org/jira/browse/KAFKA-3558
> Project: Kafka
> Issue Type: Improvement
> Components: system tests
> Reporter: Ismael Juma
> Assignee: Ismael Juma
>
> Our nightly performance tests should include scenarios involving compression.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)