You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2019/06/17 12:42:59 UTC
[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #977: (HDFS-14541)when evictableMmapped or evictable size is zero, do not throw NoSuchE…
hadoop-yetus commented on a change in pull request #977: (HDFS-14541)when evictableMmapped or evictable size is zero, do not throw NoSuchE…
URL: https://github.com/apache/hadoop/pull/977#discussion_r294277928
##########
File path: hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/ShortCircuitCache.java
##########
@@ -540,16 +538,18 @@ private void trimEvictionMaps() {
return;
}
ShortCircuitReplica replica;
- try {
- if (evictableSize == 0) {
- replica = (ShortCircuitReplica)evictableMmapped.get(evictableMmapped
- .firstKey());
- } else {
- replica = (ShortCircuitReplica)evictable.get(evictable.firstKey());
- }
- } catch (NoSuchElementException e) {
- break;
+ // maxTotalSize > 0
+ // if evictableSize == 0, evictableMmappedSize > 0 evictableMmapped do not
+ // throw NoSuchElementException
+ // if evictableMmappedSize == 0, evictableSize > 0 evictable do not throw
+ // NoSuchElementException
+ if (evictableSize == 0) {
+ replica = (ShortCircuitReplica) evictableMmapped
+ .get(evictableMmapped.firstKey());
+ } else {
+ replica = (ShortCircuitReplica) evictable.get(evictable.firstKey());
}
+
Review comment:
whitespace:end of line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org