You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Julian Reschke (JIRA)" <ji...@apache.org> on 2015/09/18 17:22:04 UTC
[jira] [Resolved] (OAK-3419) ClusterNodeInfo.createInstance fails
to clean up random entries
[ https://issues.apache.org/jira/browse/OAK-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julian Reschke resolved OAK-3419.
---------------------------------
Resolution: Fixed
trunk: http://svn.apache.org/r1703878
1.2: http://svn.apache.org/r1703882
1.0: http://svn.apache.org/r1703883
> ClusterNodeInfo.createInstance fails to clean up random entries
> ---------------------------------------------------------------
>
> Key: OAK-3419
> URL: https://issues.apache.org/jira/browse/OAK-3419
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
> Affects Versions: 1.2.4, 1.3.5, 1.0.19
> Reporter: Julian Reschke
> Assignee: Julian Reschke
> Labels: resilience
> Fix For: 1.3.7, 1.2.7, 1.0.22
>
>
> {code}
> String mId = "" + doc.get(MACHINE_ID_KEY);
> String iId = "" + doc.get(INSTANCE_ID_KEY);
> if (machineId.startsWith(RANDOM_PREFIX)) {
> // remove expired entries with random keys
> store.remove(Collection.CLUSTER_NODES, key);
> continue;
> }
> {code}
> The intent seems to be to cleanup entries in the cluster node table that start with RANDOM_PREFIX. However, {{machineId}} is checked instead of {{mId}}. When {{createInstance}} is called with a random id, the whole table might get wiped out.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)